ServerResource::decorator() - Code Metrics - Inspection of "Continue work on server tariffs management" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ef2c0c...0622f1 )

by Dmitry

created 2016-09-06 07:56 UTC

ServerResource::decorator() A

↳ Parent: ServerResource

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	0
cts	7
cp	0
rs	9.4285
cc	2
eloc	4
nc	2
nop	0
crap	6

<?php

/*
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\models;

use hipanel\base\ModelTrait;
use hipanel\modules\finance\models\decorators\AbstractResourceDecorator;
use hipanel\modules\finance\models\decorators\server\AbstractServerResourceDecorator;
use hipanel\modules\finance\models\decorators\server\BackupResourceDecorator;
use hipanel\modules\finance\models\decorators\server\ServerResourceDecoratorFactory;
use Yii;

/**
 * Class DomainResource
 * @package hipanel\modules\finance\models
 */
class ServerResource extends Resource
{
    use ModelTrait;

    public static function index()
    {
        return 'resources';
    }

    public static function type()
    {
        return 'resource';
    }

    const MODEL_TYPE_CPU = 'cpu';
    const MODEL_TYPE_RAM = 'ram';
    const MODEL_TYPE_HDD = 'hdd';
    const MODEL_TYPE_CHASSIS = 'chassis';

    const TYPE_ISP5 = 'isp5';
    const TYPE_ISP = 'isp';
    const TYPE_SUPPORT_TIME = 'support_time';
    const TYPE_IP_NUMBER = 'ip_num';
    const TYPE_SERVER_TRAF_MAX = 'server_traf_max';
    const TYPE_SERVER_TRAF95_MAX = 'server_traf95_max';
    const TYPE_BACKUP_DU = 'backup_du';

    public function rules()
    {
        $rules = parent::rules();
        $rules[] = [['model_type', 'partno'], 'safe'];

        return $rules;
    }

    /**
     * @return array
     */
    public function getModelTypes()
    {
        return [
            static::MODEL_TYPE_CPU => Yii::t('hipanel/finance/tariff', 'CPU'),
            static::MODEL_TYPE_RAM => Yii::t('hipanel/finance/tariff', 'RAM'),
            static::MODEL_TYPE_HDD => Yii::t('hipanel/finance/tariff', 'HDD'),
            static::MODEL_TYPE_CHASSIS => Yii::t('hipanel/finance/tariff', 'Chassis'),
        ];
    }

    public function isModelTypeCorrect()
    {
        return isset($this->getModelTypes()[$this->model_type]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    public function getAvailableTypes()
    {
        return [
            static::TYPE_ISP5 => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
            static::TYPE_ISP => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
            static::TYPE_SUPPORT_TIME => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
            static::TYPE_IP_NUMBER => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
            static::TYPE_SERVER_TRAF_MAX => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
            static::TYPE_SERVER_TRAF95_MAX => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
            static::TYPE_BACKUP_DU => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
        ];
    }

    /**
     * @return AbstractResourceDecorator
     */
    public function decorator()
    {
        if (empty($this->decorator)) {
            $this->decorator = ServerResourceDecoratorFactory::createFromResource($this);
        }

        return $this->decorator;
    }
}


1			<?php
2
3			/*
4			* Finance module for HiPanel
5			*
6			* @link https://github.com/hiqdev/hipanel-module-finance
7			* @package hipanel-module-finance
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hipanel\modules\finance\models;
13
14			use hipanel\base\ModelTrait;
15			use hipanel\modules\finance\models\decorators\AbstractResourceDecorator;
16			use hipanel\modules\finance\models\decorators\server\AbstractServerResourceDecorator;
17			use hipanel\modules\finance\models\decorators\server\BackupResourceDecorator;
18			use hipanel\modules\finance\models\decorators\server\ServerResourceDecoratorFactory;
19			use Yii;
20
21			/**
22			* Class DomainResource
23			* @package hipanel\modules\finance\models
24			*/
25			class ServerResource extends Resource
26			{
27			use ModelTrait;
28
29			public static function index()
30			{
31			return 'resources';
32			}
33
34			public static function type()
35			{
36			return 'resource';
37			}
38
39			const MODEL_TYPE_CPU = 'cpu';
40			const MODEL_TYPE_RAM = 'ram';
41			const MODEL_TYPE_HDD = 'hdd';
42			const MODEL_TYPE_CHASSIS = 'chassis';
43
44			const TYPE_ISP5 = 'isp5';
45			const TYPE_ISP = 'isp';
46			const TYPE_SUPPORT_TIME = 'support_time';
47			const TYPE_IP_NUMBER = 'ip_num';
48			const TYPE_SERVER_TRAF_MAX = 'server_traf_max';
49			const TYPE_SERVER_TRAF95_MAX = 'server_traf95_max';
50			const TYPE_BACKUP_DU = 'backup_du';
51
52			public function rules()
53			{
54			$rules = parent::rules();
55			$rules[] = [['model_type', 'partno'], 'safe'];
56
57			return $rules;
58			}
59
60			/**
61			* @return array
62			*/
63			public function getModelTypes()
64			{
65			return [
66			static::MODEL_TYPE_CPU => Yii::t('hipanel/finance/tariff', 'CPU'),
67			static::MODEL_TYPE_RAM => Yii::t('hipanel/finance/tariff', 'RAM'),
68			static::MODEL_TYPE_HDD => Yii::t('hipanel/finance/tariff', 'HDD'),
69			static::MODEL_TYPE_CHASSIS => Yii::t('hipanel/finance/tariff', 'Chassis'),
70			];
71			}
72
73			public function isModelTypeCorrect()
74			{
75			return isset($this->getModelTypes()[$this->model_type]);
			0 ignored issues – show Documentation introduced 2016-08-31 13:53 UTC by Report Bug Copy Issue Report The property `model_type` does not exist on `object<hipanel\modules\f...\models\ServerResource>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
76			}
77
78
79			public function getAvailableTypes()
80			{
81			return [
82			static::TYPE_ISP5 => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
83			static::TYPE_ISP => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
84			static::TYPE_SUPPORT_TIME => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
85			static::TYPE_IP_NUMBER => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
86			static::TYPE_SERVER_TRAF_MAX => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
87			static::TYPE_SERVER_TRAF95_MAX => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
88			static::TYPE_BACKUP_DU => Yii::t('hipanel/finance/tariff', 'ISP Manager'),
89			];
90			}
91
92			/**
93			* @return AbstractResourceDecorator
94			*/
95			public function decorator()
96			{
97			if (empty($this->decorator)) {
98			$this->decorator = ServerResourceDecoratorFactory::createFromResource($this);
99			}
100
101			return $this->decorator;
102			}
103			}
104

hiqdev / hipanel-module-finance

Push — master ( ef2c0c...0622f1 )

ServerResource::decorator() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like