SpeedResourceDecorator - Code Metrics - Inspection of "Continue work on server tariffs management" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ef2c0c...0622f1 )

by Dmitry

created 2016-09-06 07:56 UTC

SpeedResourceDecorator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	1
cbo	2
dl	0
loc	37
ccs	0
cts	28
cp	0
rs	10

7 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	displayTitle()	4	1
A	displayValue()	4	1
A	displayUnit()	4	1
A	getOverusePrice()	4	1
A	displayOverusePrice()	4	1
A	getPrepaidQuantity()	4	1

<?php

namespace hipanel\modules\finance\models\decorators\server;

use Yii;

class SpeedResourceDecorator extends AbstractServerResourceDecorator
{
    public function __construct()
    {
        return;
    }

    public function displayTitle()
    {
        return Yii::t('hipanel/server/order', 'Traffic');
    }

    public function displayValue()
    {
        return Yii::t('yii', '{nFormatted} GB', ['nFormatted' => $this->resource->quantity]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function displayUnit()
    {
        return Yii::t('hipanel/server/order', '{n} Gbit/s', ['n' => 1]);
    }

    public function getPrepaidQuantity()
    {
        return 1;
    }

    public function getOverusePrice()
    {
        return null;
    }

    public function displayOverusePrice()
    {
        return null;
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\models\decorators\server;
4
5			use Yii;
6
7			class SpeedResourceDecorator extends AbstractServerResourceDecorator
8			{
9			public function __construct()
10			{
11			return;
12			}
13
14			public function displayTitle()
15			{
16			return Yii::t('hipanel/server/order', 'Traffic');
17			}
18
19			public function displayValue()
20			{
21			return Yii::t('yii', '{nFormatted} GB', ['nFormatted' => $this->resource->quantity]);
			0 ignored issues – show Documentation introduced 2016-09-02 14:24 UTC by Report Bug Copy Issue Report The property `quantity` does not exist on `object<hipanel\modules\f...\models\ServerResource>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
22			}
23
24			public function displayUnit()
25			{
26			return Yii::t('hipanel/server/order', '{n} Gbit/s', ['n' => 1]);
27			}
28
29			public function getPrepaidQuantity()
30			{
31			return 1;
32			}
33
34			public function getOverusePrice()
35			{
36			return null;
37			}
38
39			public function displayOverusePrice()
40			{
41			return null;
42			}
43			}
44

hiqdev / hipanel-module-finance

Push — master ( ef2c0c...0622f1 )

SpeedResourceDecorator A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like