Price::instantiate() - Code Metrics - Inspection of "Deep coding. Implemeted template plans creating an..." - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 958dbc...2d3a59 )

by Dmitry

created 2018-02-09 10:20 UTC

Price::instantiate() A

↳ Parent: Price

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1

<?php

namespace hipanel\modules\finance\models;

use hipanel\models\Ref;
use hipanel\modules\finance\models\factories\PriceModelFactory;
use Yii;
use yii\helpers\Inflector;
use yii\helpers\StringHelper;

/**
 * Class Price
 *
 * @property int $id
 * @property int $plan_id
 * @property string|int $object_id
 * @property string|float $price
 * @property string $currency
 * @property string|int $main_object_id
 * @property string $unit
 *
 * @property TargetObject $object
 * @property Plan $plan
 *
 * @author Dmytro Naumenko <[email protected]>
 */
class Price extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    const SCENARIO_CREATE = 'create';
    const SCENARIO_UPDATE = 'update';
    const SCENARIO_DELETE = 'delete';

    public function rules()
    {
        return array_merge(parent::rules(), [
            [['id', 'parent_id', 'plan_id', 'object_id', 'type_id', 'unit_id', 'currency_id', 'main_object_id'], 'integer'],
            [['type', 'plan_name', 'unit', 'currency', 'note', 'data'], 'string'],
            [['quantity', 'price'], 'number'],
            [['class'], 'string'], // todo: probably, refactor is needed

            [['plan_id', 'type', 'price', 'currency'], 'required', 'on' => ['create', 'update']],
            [['id'], 'required', 'on' => ['update', 'set-note', 'delete']],
            [['class'], 'default', 'value' => function ($model) {

                return (new \ReflectionClass($this))->getShortName();
            }],
            [['class'], 'string'],
        ]);
    }

    public function attributeLabels()

    {
        return [
            'plan_id' => Yii::t('hipanel:finance', 'Plan'),
            'plan' => Yii::t('hipanel:finance', 'Plan'),
            'quantity' => Yii::t('hipanel:finance', 'Prepaid'),
            'unit' => Yii::t('hipanel:finance', 'Unit'),
            'price' => Yii::t('hipanel:finance', 'Price'),
            'note' => Yii::t('hipanel', 'Note'),
            'type' => Yii::t('hipanel', 'Type'),
        ];
    }

    public function getTypeOptions()

    {
        return Ref::getList('type,bill', null, [
            'select' => 'oname_label',
            'pnames' => 'monthly,overuse',
            'with_recursive' => 1,
            'mapOptions' => ['from' => 'oname'],
        ]);
    }

    public function getUnitOptions()

    {
        return Ref::getList('type,unit', null, [
            'with_recursive' => 1,
            'select' => 'oname_label',
            'mapOptions' => ['from' => 'oname'],
        ]);
    }

    public function getCurrencyOptions()
    {
        return Ref::getList('type,currency');
    }

    public function getObject()
    {
        return $this->hasOne(TargetObject::class, ['id' => 'id']);
    }

    public function getPlan()
    {
        return $this->hasOne(Plan::class, ['id' => 'plan_id']);
    }

    public static function tableName()
    {
        return Inflector::camel2id(StringHelper::basename(__CLASS__), '-');
    }

    /**
     * {@inheritdoc}
     */
    public static function instantiate($row)
    {
        if (empty($row['class'])) {
            return parent::instance($row);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }

        /** @var PriceModelFactory $factory */
        $factory = Yii::$container->get(PriceModelFactory::class);
        return $factory->build($row['class']);
    }
}


1		<?php
2
3		namespace hipanel\modules\finance\models;
4
5		use hipanel\models\Ref;
6		use hipanel\modules\finance\models\factories\PriceModelFactory;
7		use Yii;
8		use yii\helpers\Inflector;
9		use yii\helpers\StringHelper;
10
11		/**
12		* Class Price
13		*
14		* @property int $id
15		* @property int $plan_id
16		* @property string\|int $object_id
17		* @property string\|float $price
18		* @property string $currency
19		* @property string\|int $main_object_id
20		* @property string $unit
21		*
22		* @property TargetObject $object
23		* @property Plan $plan
24		*
25		* @author Dmytro Naumenko <[email protected]>
26		*/
27		class Price extends \hipanel\base\Model
28		{
29		use \hipanel\base\ModelTrait;
30
31		const SCENARIO_CREATE = 'create';
32		const SCENARIO_UPDATE = 'update';
33		const SCENARIO_DELETE = 'delete';
34
35		public function rules()
36		{
37		return array_merge(parent::rules(), [
38		[['id', 'parent_id', 'plan_id', 'object_id', 'type_id', 'unit_id', 'currency_id', 'main_object_id'], 'integer'],
39		[['type', 'plan_name', 'unit', 'currency', 'note', 'data'], 'string'],
40		[['quantity', 'price'], 'number'],
41		[['class'], 'string'], // todo: probably, refactor is needed
42
43		[['plan_id', 'type', 'price', 'currency'], 'required', 'on' => ['create', 'update']],
44		[['id'], 'required', 'on' => ['update', 'set-note', 'delete']],
45		[['class'], 'default', 'value' => function ($model) {
		0 ignored issues – show Unused Code introduced 2018-02-09 10:26 UTC by Report Bug Copy Issue Report The parameter `$model` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
46		return (new \ReflectionClass($this))->getShortName();
47		}],
48		[['class'], 'string'],
49		]);
50		}
51
52	View Code Duplication	public function attributeLabels()
		0 ignored issues – show Duplication introduced 2018-02-09 10:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		return [
55		'plan_id' => Yii::t('hipanel:finance', 'Plan'),
56		'plan' => Yii::t('hipanel:finance', 'Plan'),
57		'quantity' => Yii::t('hipanel:finance', 'Prepaid'),
58		'unit' => Yii::t('hipanel:finance', 'Unit'),
59		'price' => Yii::t('hipanel:finance', 'Price'),
60		'note' => Yii::t('hipanel', 'Note'),
61		'type' => Yii::t('hipanel', 'Type'),
62		];
63		}
64
65	View Code Duplication	public function getTypeOptions()
		0 ignored issues – show Duplication introduced 2018-01-04 15:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		{
67		return Ref::getList('type,bill', null, [
68		'select' => 'oname_label',
69		'pnames' => 'monthly,overuse',
70		'with_recursive' => 1,
71		'mapOptions' => ['from' => 'oname'],
72		]);
73		}
74
75	View Code Duplication	public function getUnitOptions()
		0 ignored issues – show Duplication introduced 2018-01-04 15:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		{
77		return Ref::getList('type,unit', null, [
78		'with_recursive' => 1,
79		'select' => 'oname_label',
80		'mapOptions' => ['from' => 'oname'],
81		]);
82		}
83
84		public function getCurrencyOptions()
85		{
86		return Ref::getList('type,currency');
87		}
88
89		public function getObject()
90		{
91		return $this->hasOne(TargetObject::class, ['id' => 'id']);
92		}
93
94		public function getPlan()
95		{
96		return $this->hasOne(Plan::class, ['id' => 'plan_id']);
97		}
98
99		public static function tableName()
100		{
101		return Inflector::camel2id(StringHelper::basename(__CLASS__), '-');
102		}
103
104		/**
105		* {@inheritdoc}
106		*/
107		public static function instantiate($row)
108		{
109		if (empty($row['class'])) {
110		return parent::instance($row);
		0 ignored issues – show Comprehensibility Bug introduced 2018-02-09 10:26 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`instance()` instead of `instantiate()`). Are you sure this is correct? If so, you might want to change this to `$this->instance()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
111		}
112
113		/** @var PriceModelFactory $factory */
114		$factory = Yii::$container->get(PriceModelFactory::class);
115		return $factory->build($row['class']);
116		}
117		}
118

hiqdev / hipanel-module-finance

Push — master ( 958dbc...2d3a59 )

Price::instantiate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like