Bill::prepareToCopy() - Code Metrics - Inspection of "Implemented bills copying" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9747b2...519d4a )

by Dmitry

created 2016-11-07 15:40 UTC

Bill::prepareToCopy() A

↳ Parent: Bill

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	7
ccs	0
cts	0
cp	0
rs	9.4285
cc	1
eloc	4
nc	1
nop	0
crap	2

<?php

/*
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\models;

use Yii;

class Bill extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    public $time_from;
    public $time_till;

    const SCENARIO_CREATE = 'create';
    const SCENARIO_UPDATE = 'update';
    const SCENARIO_DELETE = 'delete';

    public static $i18nDictionary = 'hipanel/finance';

    /**
     * {@inheritdoc}
     */
    public function rules()
    {
        return [
            [['client_id', 'seller_id', 'id'], 'integer'],
            [['object_id', 'tariff_id'], 'integer'],
            [['client', 'seller', 'bill'], 'safe'],
            [['domain', 'server'], 'safe'],
            [['sum', 'balance', 'quantity'], 'number'],
            [['currency', 'label', 'descr'], 'safe'],
            [['object', 'domains', 'tariff'], 'safe'],
            [['type', 'gtype', 'class'], 'safe'],
            [['class_label'], 'safe'],
            [['type_label', 'gtype_label'], 'safe'],
            [['time'], 'date', 'format' => 'php:d.m.Y H:i:s'],

            [['id'], 'required', 'on' => [self::SCENARIO_UPDATE, self::SCENARIO_DELETE]],
            [['client_id'], 'integer', 'on' => [self::SCENARIO_CREATE]],
            [['currency', 'sum', 'type', 'label'], 'required', 'on' => [self::SCENARIO_CREATE, self::SCENARIO_UPDATE]],
            [['client_id', 'sum', 'time'], 'required', 'on' => [self::SCENARIO_CREATE]],
            [['client'], 'safe', 'on' => [self::SCENARIO_CREATE]],
        ];
    }

    /**
     * {@inheritdoc}
     */
    public function attributeLabels()
    {
        return $this->mergeAttributeLabels([
            'client' => Yii::t('hipanel', 'Client'),
            'time' => Yii::t('hipanel', 'Time'),
            'currency' => Yii::t('hipanel', 'Currency'),
            'balance' => Yii::t('hipanel', 'Balance'),
            'gtype' => Yii::t('hipanel', 'Type'),
            'gtype_label' => Yii::t('hipanel', 'Type'),
            'sum' => Yii::t('hipanel/finance', 'Sum'),
            'tariff' => Yii::t('hipanel/finance', 'Tariff'),
            'tariff_id' => Yii::t('hipanel/finance', 'Tariff'),
        ]);
    }

    public function prepareToCopy()
    {
        $this->id = null;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->setIsNewRecord(true);

        return true;
    }
}


1			<?php
2
3			/*
4			* Finance module for HiPanel
5			*
6			* @link https://github.com/hiqdev/hipanel-module-finance
7			* @package hipanel-module-finance
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hipanel\modules\finance\models;
13
14			use Yii;
15
16			class Bill extends \hipanel\base\Model
17			{
18			use \hipanel\base\ModelTrait;
19
20			public $time_from;
21			public $time_till;
22
23			const SCENARIO_CREATE = 'create';
24			const SCENARIO_UPDATE = 'update';
25			const SCENARIO_DELETE = 'delete';
26
27			public static $i18nDictionary = 'hipanel/finance';
28
29			/**
30			* {@inheritdoc}
31			*/
32			public function rules()
33			{
34			return [
35			[['client_id', 'seller_id', 'id'], 'integer'],
36			[['object_id', 'tariff_id'], 'integer'],
37			[['client', 'seller', 'bill'], 'safe'],
38			[['domain', 'server'], 'safe'],
39			[['sum', 'balance', 'quantity'], 'number'],
40			[['currency', 'label', 'descr'], 'safe'],
41			[['object', 'domains', 'tariff'], 'safe'],
42			[['type', 'gtype', 'class'], 'safe'],
43			[['class_label'], 'safe'],
44			[['type_label', 'gtype_label'], 'safe'],
45			[['time'], 'date', 'format' => 'php:d.m.Y H:i:s'],
46
47			[['id'], 'required', 'on' => [self::SCENARIO_UPDATE, self::SCENARIO_DELETE]],
48			[['client_id'], 'integer', 'on' => [self::SCENARIO_CREATE]],
49			[['currency', 'sum', 'type', 'label'], 'required', 'on' => [self::SCENARIO_CREATE, self::SCENARIO_UPDATE]],
50			[['client_id', 'sum', 'time'], 'required', 'on' => [self::SCENARIO_CREATE]],
51			[['client'], 'safe', 'on' => [self::SCENARIO_CREATE]],
52			];
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			public function attributeLabels()
59			{
60			return $this->mergeAttributeLabels([
61			'client' => Yii::t('hipanel', 'Client'),
62			'time' => Yii::t('hipanel', 'Time'),
63			'currency' => Yii::t('hipanel', 'Currency'),
64			'balance' => Yii::t('hipanel', 'Balance'),
65			'gtype' => Yii::t('hipanel', 'Type'),
66			'gtype_label' => Yii::t('hipanel', 'Type'),
67			'sum' => Yii::t('hipanel/finance', 'Sum'),
68			'tariff' => Yii::t('hipanel/finance', 'Tariff'),
69			'tariff_id' => Yii::t('hipanel/finance', 'Tariff'),
70			]);
71			}
72
73			public function prepareToCopy()
74			{
75			$this->id = null;
			0 ignored issues – show Documentation introduced 2016-11-07 15:56 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<hipanel\modules\finance\models\Bill>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
76			$this->setIsNewRecord(true);
77
78			return true;
79			}
80			}
81

hiqdev / hipanel-module-finance

Push — master ( 9747b2...519d4a )

Bill::prepareToCopy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like