hipanel\modules\finance\controllers\PayController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	102
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	8

Test Coverage

Coverage

8.51%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getMerchantModule()	0	4	1
A	render()	0	4	1
A	completeTransaction()	0	18	4
A	actions()	0	13	2
A	actionProxyNotification()	0	12	1
A	checkNotify()	0	36	5

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\controllers;

use hipanel\modules\finance\models\Merchant;
use hiqdev\hiart\ResponseErrorException;
use hiqdev\yii2\merchant\actions\RequestAction;
use hiqdev\yii2\merchant\events\TransactionInsertEvent;
use hiqdev\yii2\merchant\transactions\Transaction;
use Yii;
use yii\base\InvalidParamException;
use yii\helpers\Json;

/**
 * Class PayController.
 * @property \hipanel\modules\finance\Module $module
 */
class PayController extends \hiqdev\yii2\merchant\controllers\PayController
{
    const SESSION_MERCHANT_LATEST_TRANSACTION_ID = 'MERCHANT_LATEST_TRANSACTION_ID';

    public function actions()
    {
        return array_merge(parent::actions(), [
            'request' => [
                'class' => RequestAction::class,
                'on ' . RequestAction::EVENT_AFTER_TRANSACTION_INSERT => function (TransactionInsertEvent $event) {
                    if ($event->transaction instanceof Transaction) {
                        Yii::$app->session->set(self::SESSION_MERCHANT_LATEST_TRANSACTION_ID, $event->transaction->getId());
                    }
                }
            ]
        ]);
    }

    public function getMerchantModule()
    {
        return $this->module->getMerchant();
    }

    public function render($view, $params = [])
    {
        return $this->getMerchantModule()->getPayController()->render($view, $params);
    }

    public function checkNotify(string $transactionId = null): ?Transaction
    {
        $id = $transactionId
            ?? Yii::$app->request->get('transactionId')
            ?? Yii::$app->request->post('transactionId')
            ?? Yii::$app->session->get(self::SESSION_MERCHANT_LATEST_TRANSACTION_ID);

        $transaction = $this->getMerchantModule()->findTransaction($id);
        if ($transaction === null) {
            return null;
        }

        $data = array_merge([
            'merchant' => $transaction->getMerchant(),
            'username' => $transaction->getParameter('username'),
        ], $_REQUEST);
        Yii::info(http_build_query($data), 'merchant');

        if (($input = file_get_contents('php://input')) !== null) {
            try {
                $data['rawBody'] = Json::decode($input);
            } catch (InvalidParamException $e) {}

Consider adding a comment why this CATCH block is empty.

        }

        try {
            return Yii::$app->get('hiart')->callWithDisabledAuth(function () use ($transaction, $data) {
                $result = Merchant::perform('pay', $data);

                $this->completeTransaction($transaction, $result);
                return $transaction;
            });
        } catch (ResponseErrorException $e) {
            // Does not matter
            return $transaction;
        }
    }

    public function actionProxyNotification()
    {
        // Currently used at least for FreeKassa integration
        $data = array_merge(Yii::$app->request->get(), Yii::$app->request->post());

        $result = Yii::$app->get('hiart')->callWithDisabledAuth(function () use ($data) {
            return Merchant::perform('pay-transaction', $data);
        });

        $this->layout = false;
        return $result;
    }

    /**
     * @param Transaction $transaction
     * @param $response
     * @return mixed
     */
    protected function completeTransaction($transaction, $response)
    {
        if ($transaction->isCompleted() || isset($data['_error'])) {

The variable $data seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

            return $transaction;
        }

        if ($response === '"OK"') {
            echo $response;
            Yii::$app->end();
        }

        $transaction->complete();
        $transaction->addParameter('bill_id', $response['id']);

        $this->getMerchantModule()->saveTransaction($transaction);

        return $transaction;
    }
}