CpuResourceDecorator::displayValue() - Code Metrics - Inspection of "Created stubs for resource decorators" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 83485f...ef2c0c )

by Dmitry

created 2016-09-02 14:19 UTC

CpuResourceDecorator::displayValue() A

↳ Parent: CpuResourceDecorator

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	0
cts	6
cp	0
rs	9.4285
cc	2
eloc	4
nc	2
nop	0
crap	6

<?php

namespace hipanel\modules\finance\models\decorators\server;

use Yii;

class CpuResourceDecorator extends AbstractServerResourceDecorator
{
    public function displayTitle()
    {
        return Yii::t('hipanel/server/order', 'CPU');
    }

    public function displayValue()
    {
        preg_match('/((\d+) cores?)$/i', $this->resource->part->partno, $matches);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $matches[2] = $matches[2] === null ? 0 : $matches[2];
        return Yii::t('hipanel/server/order', '{0, plural, one{# core} other{# cores}}', $matches[2]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\models\decorators\server;
4
5			use Yii;
6
7			class CpuResourceDecorator extends AbstractServerResourceDecorator
8			{
9			public function displayTitle()
10			{
11			return Yii::t('hipanel/server/order', 'CPU');
12			}
13
14			public function displayValue()
15			{
16			preg_match('/((\d+) cores?)$/i', $this->resource->part->partno, $matches);
			0 ignored issues – show Documentation introduced 2016-09-02 14:24 UTC by Report Bug Copy Issue Report The property `part` does not exist on `object<hipanel\modules\f...\models\ServerResource>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
17			$matches[2] = $matches[2] === null ? 0 : $matches[2];
18			return Yii::t('hipanel/server/order', '{0, plural, one{# core} other{# cores}}', $matches[2]);
			0 ignored issues – show Documentation introduced 2016-09-02 14:24 UTC by Report Bug Copy Issue Report `$matches[2]` is of type `integer\|string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19			}
20			}
21

hiqdev / hipanel-module-finance

Push — master ( 83485f...ef2c0c )

CpuResourceDecorator::displayValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like