VdsTariffForm::getBaseResource() - Code Metrics - Inspection of "Created stubs for resource decorators" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 83485f...ef2c0c )

by Dmitry

created 2016-09-02 14:19 UTC

VdsTariffForm::getBaseResource() A

↳ Parent: VdsTariffForm

Complexity

Conditions	2
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	0
cts	5
cp	0
rs	9.4285
cc	2
eloc	3
nc	1
nop	1
crap	6

<?php

namespace hipanel\modules\finance\forms;

use hipanel\modules\finance\models\DomainResource;
use hipanel\modules\finance\models\ServerResource;
use hipanel\modules\server\models\Package;

class VdsTariffForm extends AbstractTariffForm
{
    public $note;
    public $label;

    protected $package;

    public function load($data)
    {
        $this->setAttributes($data[$this->formName()]);
        $this->setResources($data[(new DomainResource())->formName()]);

        return true;
    }

    public function rules()
    {
        $rules = parent::rules();
        $rules[] = [['note', 'label'], 'safe', 'on' => ['create', 'update']];

        return $rules;
    }

    /**
     * @return \hipanel\modules\finance\models\ServerResource[]
     */
    public function getHardwareResources()
    {
        return array_filter($this->tariff->resources, function ($model) {
            /** @var ServerResource $model */
            return $model->isModelTypeCorrect();
        });
    }

    /**
     * @return \hipanel\modules\finance\models\ServerResource[]
     */
    public function getOveruseResources()
    {
        return array_filter($this->tariff->resources, function ($model) {
            /** @var ServerResource $model */
            return $model->isTypeCorrect();
        });
    }

    public function getBaseResource($type_id)
    {
        return reset(array_filter($this->baseTariff->resources, function ($resource) use ($type_id) {

            return $resource->type_id == $type_id && $resource->isTypeCorrect();
        }));
    }

    /**
     * @return \hipanel\modules\finance\models\ServerResource[]
     */
    public function getBaseHardwareResource($object_id)
    {
        return reset(array_filter($this->baseTariff->resources, function ($resource) use ($object_id) {

            /** @var ServerResource $model */
            return $resource->object_id == $object_id && $resource->isModelTypeCorrect();
        }));
    }

    public function getPackage()
    {
        if (!$this->package instanceof Package) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $this->package = new Package([
                'tariff' => $this->tariff,
            ]);
        }

        return $this->package;
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\forms;
4
5			use hipanel\modules\finance\models\DomainResource;
6			use hipanel\modules\finance\models\ServerResource;
7			use hipanel\modules\server\models\Package;
8
9			class VdsTariffForm extends AbstractTariffForm
10			{
11			public $note;
12			public $label;
13
14			protected $package;
15
16			public function load($data)
17			{
18			$this->setAttributes($data[$this->formName()]);
19			$this->setResources($data[(new DomainResource())->formName()]);
20
21			return true;
22			}
23
24			public function rules()
25			{
26			$rules = parent::rules();
27			$rules[] = [['note', 'label'], 'safe', 'on' => ['create', 'update']];
28
29			return $rules;
30			}
31
32			/**
33			* @return \hipanel\modules\finance\models\ServerResource[]
34			*/
35			public function getHardwareResources()
36			{
37			return array_filter($this->tariff->resources, function ($model) {
38			/** @var ServerResource $model */
39			return $model->isModelTypeCorrect();
40			});
41			}
42
43			/**
44			* @return \hipanel\modules\finance\models\ServerResource[]
45			*/
46			public function getOveruseResources()
47			{
48			return array_filter($this->tariff->resources, function ($model) {
49			/** @var ServerResource $model */
50			return $model->isTypeCorrect();
51			});
52			}
53
54			public function getBaseResource($type_id)
55			{
56			return reset(array_filter($this->baseTariff->resources, function ($resource) use ($type_id) {
			0 ignored issues – show Bug introduced 2016-09-02 14:24 UTC by Report Bug Copy Issue Report `array_filter($this->base...ce->isTypeCorrect(); })` cannot be passed to `reset()` as the parameter `$array` expects a reference. Loading history...
57			return $resource->type_id == $type_id && $resource->isTypeCorrect();
58			}));
59			}
60
61			/**
62			* @return \hipanel\modules\finance\models\ServerResource[]
63			*/
64			public function getBaseHardwareResource($object_id)
65			{
66			return reset(array_filter($this->baseTariff->resources, function ($resource) use ($object_id) {
			0 ignored issues – show Bug introduced 2016-09-02 14:24 UTC by Report Bug Copy Issue Report `array_filter($this->base...sModelTypeCorrect(); })` cannot be passed to `reset()` as the parameter `$array` expects a reference. Loading history...
67			/** @var ServerResource $model */
68			return $resource->object_id == $object_id && $resource->isModelTypeCorrect();
69			}));
70			}
71
72			public function getPackage()
73			{
74			if (!$this->package instanceof Package) {
			0 ignored issues – show Bug introduced 2016-08-31 13:53 UTC by Report Bug Copy Issue Report The class `hipanel\modules\server\models\Package` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
75			$this->package = new Package([
76			'tariff' => $this->tariff,
77			]);
78			}
79
80			return $this->package;
81			}
82			}
83

hiqdev / hipanel-module-finance

Push — master ( 83485f...ef2c0c )

VdsTariffForm::getBaseResource() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like