Completed
Push — master ( 4aeceb...c161f7 )
by Dmitry
04:53
created

PriceType::titlelize()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 1
1
<?php
2
3
namespace hipanel\modules\finance\widgets;
4
5
use hipanel\widgets\Type;
6
7
class PriceType extends Type
8
{
9
    public $values = [];
10
    public $defaultValues = [
11
        'success' => [
12
            'monthly,rack_unit',
13
            'monthly,ip_num',
14
            'monthly,support_time',
15
            'monthly,backup_du',
16
            'monthly,server_traf_max',
17
            'monthly,server_traf95_max',
18
            'monthly,server_du',
19
            'monthly,server_ssd',
20
            'monthly,server_sata',
21
        ],
22
        'info' => [
23
            'overuse,rack_unit',
24
            'overuse,ip_num',
25
            'overuse,support_time',
26
            'overuse,backup_du',
27
            'overuse,server_traf_max',
28
            'overuse,server_traf95_max',
29
            'overuse,server_du',
30
            'overuse,server_ssd',
31
            'overuse,server_sata',
32
        ],
33
        'warning' => [
34
            'monthly,monthly',
35
        ],
36
        'default' => [
37
            'monthly,hardware'
38
        ]
39
    ];
40
    public $field = 'type';
41
    public $i18nDictionary = 'hipanel.finance.priceTypes';
42
43
    protected function titlelize(string $label): string
44
    {
45
        return parent::titlelize(substr($label, strpos($label, ',')+1));
0 ignored issues
show
Bug introduced by
It seems like you code against a specific sub-type and not the parent class hipanel\widgets\Type as the method titlelize() does only exist in the following sub-classes of hipanel\widgets\Type: hipanel\modules\finance\widgets\PriceType. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
46
    }
47
}
48
49
50