PlanQuery::withPrices() - Code Metrics - Inspection of "created displaying of tariff history in plan/view..." - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 691d80...8f3098 )

by Dmitry

created 2020-01-31 15:19 UTC

PlanQuery::withPrices() A

↳ Parent: PlanQuery

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	11
loc	11
ccs	0
cts	10
cp	0
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\models\query;

use hipanel\modules\finance\models\Plan;
use hiqdev\hiart\ActiveQuery;

class PlanQuery extends \hiqdev\hiart\ActiveQuery
{
    public function byId($id)
    {
        return $this->andWhere(['id' => $id]);
    }

    /**
     * @param null $db
     * @return Plan|null
     */
    public function one($db = null)
    {
        return parent::one($db);

    }

    /**
     * @param null $db
     * @return Plan[]
     */
    public function all($db = null)
    {
        return parent::all($db);
    }

    public function withPrices()

    {
        return $this->with([
            'prices' => function (ActiveQuery $query) {
                $query
                    ->addSelect('main_object_id')
                    ->joinWith('object')
                    ->limit(-1);
            },
        ]);
    }

    public function joinWithPrices()

    {
        return $this->joinWith([
            'prices' => function (ActiveQuery $query) {
                $query
                    ->addSelect('main_object_id')
                    ->joinWith('object')
                    ->limit(-1);
            },
        ]);
    }

    /**
     * @return $this
     */
    public function withSales()
    {
        $this
            ->joinWith('sales')
            ->andWhere(['state' => ['ok', 'deleted']]);

        return $this;
    }

    /**
     * @return $this
     */
    public function withPriceHistory()
    {
        $this
            ->joinWith([
                'priceHistory' => function (ActiveQuery $query): void {
                    $query
                        ->addSelect('main_object_id')
                        ->joinWith('object');
                },
            ])
            ->andWhere(['priceHistory' => true]);

        return $this;
    }
}


1		<?php
2		/**
3		* Finance module for HiPanel
4		*
5		* @link https://github.com/hiqdev/hipanel-module-finance
6		* @package hipanel-module-finance
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hipanel\modules\finance\models\query;
12
13		use hipanel\modules\finance\models\Plan;
14		use hiqdev\hiart\ActiveQuery;
15
16		class PlanQuery extends \hiqdev\hiart\ActiveQuery
17		{
18		public function byId($id)
19		{
20		return $this->andWhere(['id' => $id]);
21		}
22
23		/**
24		* @param null $db
25		* @return Plan\|null
26		*/
27		public function one($db = null)
28		{
29		return parent::one($db);
		0 ignored issues – show Bug Compatibility introduced 2018-07-16 13:43 UTC by Report Bug Copy Issue Report The expression `parent::one($db);` of type `hiqdev\hiart\ActiveRecord\|array\|null` adds the type `hiqdev\hiart\ActiveRecord` to the return on line 29 which is incompatible with the return type declared by the interface `yii\db\QueryInterface::one` of type `array\|boolean`. Loading history...
30		}
31
32		/**
33		* @param null $db
34		* @return Plan[]
35		*/
36		public function all($db = null)
37		{
38		return parent::all($db);
39		}
40
41	View Code Duplication	public function withPrices()
		0 ignored issues – show Duplication introduced 2019-02-15 10:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		{
43		return $this->with([
44		'prices' => function (ActiveQuery $query) {
45		$query
46		->addSelect('main_object_id')
47		->joinWith('object')
48		->limit(-1);
49		},
50		]);
51		}
52
53	View Code Duplication	public function joinWithPrices()
		0 ignored issues – show Duplication introduced 2019-02-15 10:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		{
55		return $this->joinWith([
56		'prices' => function (ActiveQuery $query) {
57		$query
58		->addSelect('main_object_id')
59		->joinWith('object')
60		->limit(-1);
61		},
62		]);
63		}
64
65		/**
66		* @return $this
67		*/
68		public function withSales()
69		{
70		$this
71		->joinWith('sales')
72		->andWhere(['state' => ['ok', 'deleted']]);
73
74		return $this;
75		}
76
77		/**
78		* @return $this
79		*/
80		public function withPriceHistory()
81		{
82		$this
83		->joinWith([
84		'priceHistory' => function (ActiveQuery $query): void {
85		$query
86		->addSelect('main_object_id')
87		->joinWith('object');
88		},
89		])
90		->andWhere(['priceHistory' => true]);
91
92		return $this;
93		}
94		}
95

hiqdev / hipanel-module-finance

Push — master ( 691d80...8f3098 )

PlanQuery::withPrices() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like