DomainTariffManager::createForm() - Code Metrics - Inspection of "Improved AbstractTariffForm, AbstractTariffManager..." - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae53ec...716429 )

by Dmitry

created 2016-08-26 16:20 UTC

DomainTariffManager::createForm() A

↳ Parent: DomainTariffManager::buildForm()

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	5
ccs	0
cts	4
cp	0
rs	9.4285
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php

namespace hipanel\modules\finance\logic;

use hipanel\modules\finance\forms\DomainTariffForm;
use hipanel\modules\finance\models\Tariff;
use hiqdev\hiart\ErrorResponseException;
use Yii;
use yii\web\NotFoundHttpException;
use yii\web\UnprocessableEntityHttpException;

class DomainTariffManager extends AbstractTariffManager

{
    /**
     * @var DomainTariffForm
     */
    public $form;

    /**
     * @inheritdoc
     */
    protected $type = 'domain';

    public function init()
    {
        parent::init();

        if (!Yii::getAlias('@domain', true)) {
            throw new NotFoundHttpException('Domain module is missing');
        }
    }

    protected function buildForm()
    {
        $this->form = new DomainTariffForm([
            'scenario' => $this->scenario,
            'zones' => $this->getZones(),
            'baseTariffs' => $this->baseTariffs,
            'tariff' => $this->tariff
        ]);
    }

    public function insert()
    {
        $data = $this->form->toArray();

        try {
            $result = Tariff::perform('Create', $data);
        } catch (ErrorResponseException $e) {
            throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
        }

        $this->form->id = $result['id'];

        return true;
    }

    public function update()
    {
        $data = $this->form->toArray();

        try {
            $result = Tariff::perform('Update', $data);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (ErrorResponseException $e) {
            throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
        }

        return true;
    }

    /**
     * @return array
     */
    protected function getZones()
    {
        return Yii::$app->hiart->get('getZones');
    }
}


1		<?php
2
3		namespace hipanel\modules\finance\logic;
4
5		use hipanel\modules\finance\forms\DomainTariffForm;
6		use hipanel\modules\finance\models\Tariff;
7		use hiqdev\hiart\ErrorResponseException;
8		use Yii;
9		use yii\web\NotFoundHttpException;
10		use yii\web\UnprocessableEntityHttpException;
11
12	View Code Duplication	class DomainTariffManager extends AbstractTariffManager
		0 ignored issues – show Duplication introduced 2016-08-26 16:35 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/**
15		* @var DomainTariffForm
16		*/
17		public $form;
18
19		/**
20		* @inheritdoc
21		*/
22		protected $type = 'domain';
23
24		public function init()
25		{
26		parent::init();
27
28		if (!Yii::getAlias('@domain', true)) {
29		throw new NotFoundHttpException('Domain module is missing');
30		}
31		}
32
33		protected function buildForm()
34		{
35		$this->form = new DomainTariffForm([
36		'scenario' => $this->scenario,
37		'zones' => $this->getZones(),
38		'baseTariffs' => $this->baseTariffs,
39		'tariff' => $this->tariff
40		]);
41		}
42
43		public function insert()
44		{
45		$data = $this->form->toArray();
46
47		try {
48		$result = Tariff::perform('Create', $data);
49		} catch (ErrorResponseException $e) {
50		throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
51		}
52
53		$this->form->id = $result['id'];
54
55		return true;
56		}
57
58		public function update()
59		{
60		$data = $this->form->toArray();
61
62		try {
63		$result = Tariff::perform('Update', $data);
		0 ignored issues – show Unused Code introduced 2016-08-18 14:58 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
64		} catch (ErrorResponseException $e) {
65		throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
66		}
67
68		return true;
69		}
70
71		/**
72		* @return array
73		*/
74		protected function getZones()
75		{
76		return Yii::$app->hiart->get('getZones');
77		}
78		}
79

hiqdev / hipanel-module-finance

Push — master ( ae53ec...716429 )

DomainTariffManager::createForm() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like