hiqdev /
hipanel-module-finance
| Conditions | 6 |
| Paths | 6 |
| Total Lines | 21 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 42 |
| Changes | 0 | ||
| 1 | <?php |
||
| 19 | public function run() |
||
| 20 | { |
||
| 21 | if ($this->merchants === null && Yii::$app->hasModule('merchant') && Yii::$app->user->can('deposit')) { |
||
| 22 | $this->merchants = Yii::$app->getModule('merchant')->getPurchaseRequestCollection()->getItems(); |
||
| 23 | } |
||
| 24 | |||
| 25 | if (empty($this->merchants)) { |
||
| 26 | return ''; |
||
| 27 | } |
||
| 28 | |||
| 29 | $list = array_map(function($merchant) { return $merchant->label; }, $this->merchants); |
||
| 30 | $htmlList = array_unique(array_map(function($merchant) { return Html::tag('b', $merchant); }, $list)); |
||
| 31 | |||
| 32 | $out[] = Yii::t('hipanel:finance', 'We accept the following automatic payment methods') . ":"; |
||
|
|
|||
| 33 | $out[] = implode(', ', $htmlList); |
||
| 34 | if (\in_array(self::PAYPAL_PROCESSING, $list, true)) { |
||
| 35 | $out[] = Yii::t('hipanel:finance', 'as well as PayPal payments from your Visa and MasterCard'); |
||
| 36 | } |
||
| 37 | |||
| 38 | return implode(" ", $out); |
||
| 39 | } |
||
| 40 | } |
||
| 41 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.