Resource - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/hiqdev..." - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e3a066...ae53ec )

by Dmitry

created 2016-08-25 15:17 UTC

Resource A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
wmc	5
c	4
b	1
f	1
lcom	0
cbo	2
dl	0
loc	45
ccs	0
cts	29
cp	0
rs	10

5 Methods

Rating	Name	Size	Complexity
A	getTariff()	4	1
A	attributeLabels()	5	1
A	rules()	13	1
A	isTypeCorrect()	4	1
A	getAvailableTypes()	4	1

<?php

/*
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\models;

class Resource extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    /**
     * {@inheritdoc}
     */
    public function rules()
    {
        return [
            [['id', 'tariff_id', 'object_id', 'type_id', 'unit_id', 'currency_id', 'hardlim'], 'integer'],
            [['type', 'ftype', 'unit', 'unit_factor', 'currency'], 'safe'],
            [['price', 'fee', 'quantity', 'discount'], 'number'],

            [['object_id', 'type_id'], 'integer', 'on' => ['create', 'update']],
            [['type'], 'safe', 'on' => ['create', 'update']],
            [['price'], 'number', 'on' => ['create', 'update']],
            'create-required' => [['object_id', 'price'], 'required', 'on' => ['create', 'update']],
        ];
    }

    public function getTariff()
    {
        return $this->hasOne(Tariff::class, ['tariff_id' => 'id']);
    }

    /**
     * {@inheritdoc}
     */
    public function attributeLabels()
    {
        return $this->mergeAttributeLabels([
        ]);
    }

    public function isTypeCorrect()
    {
        return isset($this->getAvailableTypes()[$this->type]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getAvailableTypes()
    {
        return [];
    }
}


1			<?php
2
3			/*
4			* Finance module for HiPanel
5			*
6			* @link https://github.com/hiqdev/hipanel-module-finance
7			* @package hipanel-module-finance
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hipanel\modules\finance\models;
13
14			class Resource extends \hipanel\base\Model
15			{
16			use \hipanel\base\ModelTrait;
17
18			/**
19			* {@inheritdoc}
20			*/
21			public function rules()
22			{
23			return [
24			[['id', 'tariff_id', 'object_id', 'type_id', 'unit_id', 'currency_id', 'hardlim'], 'integer'],
25			[['type', 'ftype', 'unit', 'unit_factor', 'currency'], 'safe'],
26			[['price', 'fee', 'quantity', 'discount'], 'number'],
27
28			[['object_id', 'type_id'], 'integer', 'on' => ['create', 'update']],
29			[['type'], 'safe', 'on' => ['create', 'update']],
30			[['price'], 'number', 'on' => ['create', 'update']],
31			'create-required' => [['object_id', 'price'], 'required', 'on' => ['create', 'update']],
32			];
33			}
34
35			public function getTariff()
36			{
37			return $this->hasOne(Tariff::class, ['tariff_id' => 'id']);
38			}
39
40			/**
41			* {@inheritdoc}
42			*/
43			public function attributeLabels()
44			{
45			return $this->mergeAttributeLabels([
46			]);
47			}
48
49			public function isTypeCorrect()
50			{
51			return isset($this->getAvailableTypes()[$this->type]);
			0 ignored issues – show Documentation introduced 2016-08-25 15:25 UTC by Report Bug Copy Issue Report The property `type` does not exist on `object<hipanel\modules\finance\models\Resource>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52			}
53
54			public function getAvailableTypes()
55			{
56			return [];
57			}
58			}
59

hiqdev / hipanel-module-finance

Push — master ( e3a066...ae53ec )

Resource A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like