ChargesGrouper::group() - Code Metrics - Inspection of "Added grouping in bill view" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#62)

by Dmitry

created 2018-11-22 15:57 UTC

ChargesGrouper::group() A

↳ Parent: ChargesGrouper

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	7
cp	0
rs	9.7666
c	0
b	0
f	0
cc	3
nc	4
nop	0
crap	12

<?php

namespace hipanel\modules\finance\helpers;

use hipanel\modules\finance\models\Charge;
use Tuck\Sort\Sort;
use Tuck\Sort\SortChain;

/**
 * Class ChargesGrouper can be used to group charges inside $charge by common_object_id
 */
class ChargesGrouper
{
    /**
     * @var Charge[]
     */
    private $charges;

    /**
     * ChargesGrouper constructor.
     * @param Charge[] $charges
     */
    public function __construct(array $charges)
    {
        $this->charges = $charges;
    }

    /**
     * @return array of two elements:
     * 0: common_object_id => common_object_id, common_object_name
     * 1: common_object_id => array Charge[][] by common_object_id
     */
    public function group()
    {
        /** @var Charge[] $idToNameObject */
        $idToNameObject = [];
        /** @var Charge[][] $chargesByMainObject */
        $chargesByMainObject = [];
        foreach ($this->charges as $charge) {
            $chargesByMainObject[$charge->common_object_id][$charge->id] = $charge;
        }
        foreach ($this->charges as $charge) {
            $idToNameObject[$charge->common_object_id] = $charge;
        }
        $idToNameObject = $this->sortByServerName()->values($idToNameObject);
        return [$idToNameObject, $chargesByMainObject];
    }

    private function sortByServerName(): SortChain
    {
        return Sort::chain()->compare(function (Charge $a, Charge $b) {
            return strnatcasecmp($a->common_object_name, $b->common_object_name);
        });
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\helpers;
4
5			use hipanel\modules\finance\models\Charge;
6			use Tuck\Sort\Sort;
7			use Tuck\Sort\SortChain;
8
9			/**
10			* Class ChargesGrouper can be used to group charges inside $charge by common_object_id
11			*/
12			class ChargesGrouper
13			{
14			/**
15			* @var Charge[]
16			*/
17			private $charges;
18
19			/**
20			* ChargesGrouper constructor.
21			* @param Charge[] $charges
22			*/
23			public function __construct(array $charges)
24			{
25			$this->charges = $charges;
26			}
27
28			/**
29			* @return array of two elements:
30			* 0: common_object_id => common_object_id, common_object_name
31			* 1: common_object_id => array Charge[][] by common_object_id
32			*/
33			public function group()
34			{
35			/** @var Charge[] $idToNameObject */
36			$idToNameObject = [];
37			/** @var Charge[][] $chargesByMainObject */
38			$chargesByMainObject = [];
39			foreach ($this->charges as $charge) {
40			$chargesByMainObject[$charge->common_object_id][$charge->id] = $charge;
41			}
42			foreach ($this->charges as $charge) {
43			$idToNameObject[$charge->common_object_id] = $charge;
44			}
45			$idToNameObject = $this->sortByServerName()->values($idToNameObject);
46			return [$idToNameObject, $chargesByMainObject];
47			}
48
49			private function sortByServerName(): SortChain
50			{
51			return Sort::chain()->compare(function (Charge $a, Charge $b) {
52			return strnatcasecmp($a->common_object_name, $b->common_object_name);
53			});
54			}
55			}
56

hiqdev / hipanel-module-finance

Pull Request — master (#62)

ChargesGrouper::group() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like