Issues in TariffProfile.php - All Issues - Inspection of "removed arrows from prices form inputs (#123)" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c2bc12...ef5bc2 )

by Dmitry

created 2019-08-19 08:47 UTC

src/models/TariffProfile.php (2 issues)

Showing only issues like (Show All)

Check for undocumented magic property with read access

Documentation Informational

Yurii Myronchuk 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\models;

use Yii;

/**
 * Class Tariff.
 * @property resource[]|DomainResource[]|ServerResource[] $resources
 */
class TariffProfile extends \hipanel\base\Model
{
    use \hipanel\base\ModelTrait;

    public static function tableName()
    {
        return 'tariffprofile';
    }

    /**
     * {@inheritdoc}
     */
    public function rules()
    {
        $main = [
            [['name'], 'safe'],
            [
                ['name'],
                'required',
                'on' => ['update', 'create'],
                'when' => function ($model) {
                    return !$model->isDefault();
                },
            ],
            [['id'], 'integer'],
            [['id'], 'required', 'on' => ['update', 'delete']],
            [['tariff_names'], 'safe'],
            [['seller_id', 'client_id'], 'integer'],
            [['seller', 'client'], 'safe'],
            [['tariffs'], 'safe'],
        ];

        $tariffTypes = [Tariff::TYPE_DOMAIN, Tariff::TYPE_CERT, Tariff::TYPE_XEN, Tariff::TYPE_OPENVZ, Tariff::TYPE_SERVER];
        foreach ($tariffTypes as $type) {
            if (in_array($type, [Tariff::TYPE_DOMAIN, Tariff::TYPE_CERT], true)) {
                $main[] = [[$type], 'integer'];
            } else {
                $main[] = [[$type], 'filter', 'filter' => function ($value) { return explode(',', $value); }];
                $main[] = [[$type], 'each', 'rule' => ['trim'], 'on' => ['update', 'create']];
                $main[] = [[$type], 'each', 'rule' => ['integer'], 'on' => ['update', 'create']];
            }
        }

        return $main;
    }

    public function beforeValidate()
    {
        foreach ([Tariff::TYPE_XEN, Tariff::TYPE_OPENVZ, Tariff::TYPE_SERVER] as $attribute) {
            if (empty($this->$attribute)) {
                continue;
            }
            $this->$attribute = reset($this->$attribute);
        }

        return parent::beforeValidate();
    }

    /**
     * {@inheritdoc}
     */
    public function attributeLabels()
    {
        return $this->mergeAttributeLabels([
            'name' => Yii::t('hipanel.finance.tariffprofile', 'Name'),
            'tariff_names' => Yii::t('hipanel.finance.tariffprofile', 'Tariffs'),
            'domain' => Yii::t('hipanel.finance.tariffprofile', 'Domain tariff'),
            'certificate' => Yii::t('hipanel.finance.tariffprofile', 'Certificate tariff'),
            'svds' => Yii::t('hipanel.finance.tariffprofile', 'XEN tariffs'),
            'ovds' => Yii::t('hipanel.finance.tariffprofile', 'Open-VZ tariffs'),
            'server' => Yii::t('hipanel.finance.tariffprofile', 'Server tariffs'),
        ]);
    }

    /**
     * Check is model is default profile
     *
     * @return bool
     */
    public function isDefault() : bool
    {
        return (bool) ((string) $this->id === (string) $this->client_id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2			/**
3			* Finance module for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-finance
6			* @package hipanel-module-finance
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\modules\finance\models;
12
13			use Yii;
14
15			/**
16			* Class Tariff.
17			* @property resource[]\|DomainResource[]\|ServerResource[] $resources
18			*/
19			class TariffProfile extends \hipanel\base\Model
20			{
21			use \hipanel\base\ModelTrait;
22
23			public static function tableName()
24			{
25			return 'tariffprofile';
26			}
27
28			/**
29			* {@inheritdoc}
30			*/
31			public function rules()
32			{
33			$main = [
34			[['name'], 'safe'],
35			[
36			['name'],
37			'required',
38			'on' => ['update', 'create'],
39			'when' => function ($model) {
40			return !$model->isDefault();
41			},
42			],
43			[['id'], 'integer'],
44			[['id'], 'required', 'on' => ['update', 'delete']],
45			[['tariff_names'], 'safe'],
46			[['seller_id', 'client_id'], 'integer'],
47			[['seller', 'client'], 'safe'],
48			[['tariffs'], 'safe'],
49			];
50
51			$tariffTypes = [Tariff::TYPE_DOMAIN, Tariff::TYPE_CERT, Tariff::TYPE_XEN, Tariff::TYPE_OPENVZ, Tariff::TYPE_SERVER];
52			foreach ($tariffTypes as $type) {
53			if (in_array($type, [Tariff::TYPE_DOMAIN, Tariff::TYPE_CERT], true)) {
54			$main[] = [[$type], 'integer'];
55			} else {
56			$main[] = [[$type], 'filter', 'filter' => function ($value) { return explode(',', $value); }];
57			$main[] = [[$type], 'each', 'rule' => ['trim'], 'on' => ['update', 'create']];
58			$main[] = [[$type], 'each', 'rule' => ['integer'], 'on' => ['update', 'create']];
59			}
60			}
61
62			return $main;
63			}
64
65			public function beforeValidate()
66			{
67			foreach ([Tariff::TYPE_XEN, Tariff::TYPE_OPENVZ, Tariff::TYPE_SERVER] as $attribute) {
68			if (empty($this->$attribute)) {
69			continue;
70			}
71			$this->$attribute = reset($this->$attribute);
72			}
73
74			return parent::beforeValidate();
75			}
76
77			/**
78			* {@inheritdoc}
79			*/
80			public function attributeLabels()
81			{
82			return $this->mergeAttributeLabels([
83			'name' => Yii::t('hipanel.finance.tariffprofile', 'Name'),
84			'tariff_names' => Yii::t('hipanel.finance.tariffprofile', 'Tariffs'),
85			'domain' => Yii::t('hipanel.finance.tariffprofile', 'Domain tariff'),
86			'certificate' => Yii::t('hipanel.finance.tariffprofile', 'Certificate tariff'),
87			'svds' => Yii::t('hipanel.finance.tariffprofile', 'XEN tariffs'),
88			'ovds' => Yii::t('hipanel.finance.tariffprofile', 'Open-VZ tariffs'),
89			'server' => Yii::t('hipanel.finance.tariffprofile', 'Server tariffs'),
90			]);
91			}
92
93			/**
94			* Check is model is default profile
95			*
96			* @return bool
97			*/
98			public function isDefault() : bool
99			{
100			return (bool) ((string) $this->id === (string) $this->client_id);
			0 ignored issues – show Documentation introduced 2019-07-31 14:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `id` does not exist on `object<hipanel\modules\f...e\models\TariffProfile>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2019-07-31 14:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `client_id` does not exist on `object<hipanel\modules\f...e\models\TariffProfile>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
101			}
102			}
103

hiqdev / hipanel-module-finance

Push — master ( c2bc12...ef5bc2 )

src/models/TariffProfile.php (2 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like