TariffController - Code Metrics - Inspection of "Implemented server tariffs management" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e3889a...e33a5f )

by Dmitry

created 2017-06-27 12:35 UTC

TariffController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	121
Duplicated Lines	64.46 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

32.65%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	20
c	1
b	0
f	0
lcom	1
cbo	7
dl	78
loc	121
ccs	16
cts	49
cp	0.3265
rs	10

8 Methods

Rating	Name	Duplication	Size	Complexity
B	actions()	0	27	1
A	actionCreateDomain()	13	13	3
A	actionCreateSvds()	14	14	3
A	actionCreateOvds()	13	13	3
A	actionCreateCertificate()	13	13	3
A	actionCreateServer()	13	13	3
A	actionUpdate()	12	12	3
A	actionView()	0	6	1

How to fix Duplicated Code

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\controllers;

use hipanel\actions\ComboSearchAction;
use hipanel\actions\IndexAction;
use hipanel\actions\SmartDeleteAction;
use hipanel\actions\SmartUpdateAction;
use hipanel\actions\ValidateFormAction;
use hipanel\models\Ref;
use hipanel\modules\finance\logic\DomainTariffManager;
use hipanel\modules\finance\logic\TariffManagerFactory;
use hipanel\modules\finance\models\CertificateResource;
use Yii;

class TariffController extends \hipanel\base\CrudController
{
    public function actions()
    {
        return [
            'index' => [
                'class' => IndexAction::class,
                'data' => function () {
                    return [
                        'types' => Ref::getList('type,tariff', 'hipanel:finance:tariff:types'),
                    ];
                },
            ],
            'search' => [
                'class' => ComboSearchAction::class,
            ],
            'validate-form' => [
                'class' => ValidateFormAction::class,
            ],
            'set-note' => [
                'class' => SmartUpdateAction::class,
                'success' => Yii::t('hipanel', 'Note updated'),
            ],
            'delete' => [
                'class' => SmartDeleteAction::class,
                'success' => Yii::t('hipanel:finance:tariff', 'Tariff deleted'),
            ],
        ];
    }

    public function actionCreateDomain()

    {
        /** @var DomainTariffManager $manager */
        $manager = TariffManagerFactory::createByType('domain');
        $form = $manager->form;

        if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
            $manager->insert();
            return $this->redirect(['view', 'id' => $form->id]);
        }

        return $this->render('domain/create', ['model' => $form]);
    }

    public function actionCreateSvds($parent_id = null)

    {
        /** @var DomainTariffManager $manager */
        $manager = TariffManagerFactory::createByType('svds', $parent_id);

        $form = $manager->form;

        if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
            $manager->insert();
            return $this->redirect(['view', 'id' => $form->id]);
        }

        return $this->render('vds/create', ['model' => $form]);
    }

    public function actionCreateOvds($parent_id = null)

    {
        /** @var DomainTariffManager $manager */
        $manager = TariffManagerFactory::createByType('ovds', $parent_id);
        $form = $manager->form;

        if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
            $manager->insert();
            return $this->redirect(['view', 'id' => $form->id]);
        }

        return $this->render('vds/create', ['model' => $form]);
    }

    public function actionCreateCertificate($parent_id = null)

    {
        /** @var CertificateResource $manager */
        $manager = TariffManagerFactory::createByType('certificate', $parent_id);
        $form = $manager->form;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
            $manager->insert();
            return $this->redirect(['view', 'id' => $form->id]);
        }

        return $this->render('certificate/create', ['model' => $form]);
    }

    public function actionCreateServer($parent_id = null)

    {
        /** @var CertificateResource $manager */
        $manager = TariffManagerFactory::createByType('server', $parent_id);
        $form = $manager->form;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
            $manager->insert();
            return $this->redirect(['view', 'id' => $form->id]);
        }

        return $this->render('server/create', ['model' => $form]);
    }

    public function actionUpdate($id)

    {
        $manager = TariffManagerFactory::createById($id, ['scenario' => 'update']);
        $form = $manager->form;

        if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
            $manager->update();
            return $this->redirect(['view', 'id' => $form->id]);
        }

        return $this->render($manager->getType() . '/update', ['model' => $form]);
    }

    public function actionView($id)
    {
        $manager = TariffManagerFactory::createById($id);

        return $this->render('view', ['manager' => $manager]);
    }
}


1			<?php
2			/**
3			* Finance module for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-finance
6			* @package hipanel-module-finance
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\modules\finance\controllers;
12
13			use hipanel\actions\ComboSearchAction;
14			use hipanel\actions\IndexAction;
15			use hipanel\actions\SmartDeleteAction;
16			use hipanel\actions\SmartUpdateAction;
17			use hipanel\actions\ValidateFormAction;
18			use hipanel\models\Ref;
19			use hipanel\modules\finance\logic\DomainTariffManager;
20			use hipanel\modules\finance\logic\TariffManagerFactory;
21			use hipanel\modules\finance\models\CertificateResource;
22			use Yii;
23
24			class TariffController extends \hipanel\base\CrudController
25	1		{
26			public function actions()
27			{
28			return [
29	1		'index' => [
30	1		'class' => IndexAction::class,
31			'data' => function () {
32			return [
33			'types' => Ref::getList('type,tariff', 'hipanel:finance:tariff:types'),
34	1		];
35	1		},
36			],
37	1		'search' => [
38	1		'class' => ComboSearchAction::class,
39			],
40	1		'validate-form' => [
41	1		'class' => ValidateFormAction::class,
42			],
43	1		'set-note' => [
44	1		'class' => SmartUpdateAction::class,
45	1		'success' => Yii::t('hipanel', 'Note updated'),
46			],
47	1		'delete' => [
48	1		'class' => SmartDeleteAction::class,
49	1		'success' => Yii::t('hipanel:finance:tariff', 'Tariff deleted'),
50	1		],
51			];
52			}
53
54		View Code Duplication	public function actionCreateDomain()
			0 ignored issues – show Duplication introduced 2016-08-18 14:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55			{
56			/** @var DomainTariffManager $manager */
57			$manager = TariffManagerFactory::createByType('domain');
58			$form = $manager->form;
59
60			if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
61			$manager->insert();
62			return $this->redirect(['view', 'id' => $form->id]);
63			}
64
65			return $this->render('domain/create', ['model' => $form]);
66			}
67
68		View Code Duplication	public function actionCreateSvds($parent_id = null)
			0 ignored issues – show Duplication introduced 2016-09-06 16:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69			{
70			/** @var DomainTariffManager $manager */
71			$manager = TariffManagerFactory::createByType('svds', $parent_id);
72
73			$form = $manager->form;
74
75			if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
76			$manager->insert();
77			return $this->redirect(['view', 'id' => $form->id]);
78			}
79
80			return $this->render('vds/create', ['model' => $form]);
81			}
82
83		View Code Duplication	public function actionCreateOvds($parent_id = null)
			0 ignored issues – show Duplication introduced 2016-09-08 16:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84			{
85			/** @var DomainTariffManager $manager */
86			$manager = TariffManagerFactory::createByType('ovds', $parent_id);
87			$form = $manager->form;
88
89			if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
90			$manager->insert();
91			return $this->redirect(['view', 'id' => $form->id]);
92			}
93
94			return $this->render('vds/create', ['model' => $form]);
95			}
96
97		View Code Duplication	public function actionCreateCertificate($parent_id = null)
			0 ignored issues – show Duplication introduced 2017-06-20 10:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98			{
99			/** @var CertificateResource $manager */
100			$manager = TariffManagerFactory::createByType('certificate', $parent_id);
101			$form = $manager->form;
			0 ignored issues – show Documentation introduced 2017-06-20 10:18 UTC by Report Bug Copy Issue Report The property `form` does not exist on `object<hipanel\modules\f...ls\CertificateResource>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
102
103			if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
104			$manager->insert();
105			return $this->redirect(['view', 'id' => $form->id]);
106			}
107
108			return $this->render('certificate/create', ['model' => $form]);
109			}
110
111		View Code Duplication	public function actionCreateServer($parent_id = null)
			0 ignored issues – show Duplication introduced 2017-06-27 12:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112			{
113			/** @var CertificateResource $manager */
114			$manager = TariffManagerFactory::createByType('server', $parent_id);
115			$form = $manager->form;
			0 ignored issues – show Documentation introduced 2017-06-27 12:39 UTC by Report Bug Copy Issue Report The property `form` does not exist on `object<hipanel\modules\f...ls\CertificateResource>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
116
117			if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
118			$manager->insert();
119			return $this->redirect(['view', 'id' => $form->id]);
120			}
121
122			return $this->render('server/create', ['model' => $form]);
123			}
124
125		View Code Duplication	public function actionUpdate($id)
			0 ignored issues – show Duplication introduced 2016-08-18 14:58 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126			{
127			$manager = TariffManagerFactory::createById($id, ['scenario' => 'update']);
128			$form = $manager->form;
129
130			if (Yii::$app->request->isPost && $form->load(Yii::$app->request->post())) {
131			$manager->update();
132			return $this->redirect(['view', 'id' => $form->id]);
133			}
134
135			return $this->render($manager->getType() . '/update', ['model' => $form]);
136			}
137
138			public function actionView($id)
139			{
140			$manager = TariffManagerFactory::createById($id);
141
142			return $this->render('view', ['manager' => $manager]);
143			}
144			}
145

hiqdev / hipanel-module-finance

Push — master ( e3889a...e33a5f )

TariffController A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like