ServerResource::getModelTypes() - Code Metrics - Inspection of "Partially implemented VDS tariffs management" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0edfe9...83485f )

by Dmitry

created 2016-08-31 13:45 UTC

ServerResource::getModelTypes() A

↳ Parent: ServerResource

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	9
ccs	0
cts	8
cp	0
rs	9.6666
cc	1
eloc	6
nc	1
nop	0
crap	2

<?php

/*
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\models;

use hipanel\base\ModelTrait;
use Yii;

/**
 * Class DomainResource
 * @package hipanel\modules\finance\models
 */
class ServerResource extends Resource
{
    use ModelTrait;

    public static function index()
    {
        return 'resources';
    }

    public static function type()
    {
        return 'resource';
    }

    const MODEL_TYPE_CPU = 'cpu';
    const MODEL_TYPE_RAM = 'ram';
    const MODEL_TYPE_HDD = 'hdd';
    const MODEL_TYPE_CHASSIS = 'chassis';

    public function rules()
    {
        $rules = parent::rules();
        $rules[] = [['model_type', 'partno'], 'safe'];

        return $rules;
    }

    /**
     * @return array
     */
    public function getModelTypes()
    {
        return [
            static::MODEL_TYPE_CPU => Yii::t('hipanel/finance/tariff', 'CPU'),
            static::MODEL_TYPE_RAM => Yii::t('hipanel/finance/tariff', 'RAM'),
            static::MODEL_TYPE_HDD => Yii::t('hipanel/finance/tariff', 'HDD'),
            static::MODEL_TYPE_CHASSIS => Yii::t('hipanel/finance/tariff', 'Chassis'),
        ];
    }

    public function isModelTypeCorrect()
    {
        return isset($this->getModelTypes()[$this->model_type]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			/*
4			* Finance module for HiPanel
5			*
6			* @link https://github.com/hiqdev/hipanel-module-finance
7			* @package hipanel-module-finance
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hipanel\modules\finance\models;
13
14			use hipanel\base\ModelTrait;
15			use Yii;
16
17			/**
18			* Class DomainResource
19			* @package hipanel\modules\finance\models
20			*/
21			class ServerResource extends Resource
22			{
23			use ModelTrait;
24
25			public static function index()
26			{
27			return 'resources';
28			}
29
30			public static function type()
31			{
32			return 'resource';
33			}
34
35			const MODEL_TYPE_CPU = 'cpu';
36			const MODEL_TYPE_RAM = 'ram';
37			const MODEL_TYPE_HDD = 'hdd';
38			const MODEL_TYPE_CHASSIS = 'chassis';
39
40			public function rules()
41			{
42			$rules = parent::rules();
43			$rules[] = [['model_type', 'partno'], 'safe'];
44
45			return $rules;
46			}
47
48			/**
49			* @return array
50			*/
51			public function getModelTypes()
52			{
53			return [
54			static::MODEL_TYPE_CPU => Yii::t('hipanel/finance/tariff', 'CPU'),
55			static::MODEL_TYPE_RAM => Yii::t('hipanel/finance/tariff', 'RAM'),
56			static::MODEL_TYPE_HDD => Yii::t('hipanel/finance/tariff', 'HDD'),
57			static::MODEL_TYPE_CHASSIS => Yii::t('hipanel/finance/tariff', 'Chassis'),
58			];
59			}
60
61			public function isModelTypeCorrect()
62			{
63			return isset($this->getModelTypes()[$this->model_type]);
			0 ignored issues – show Documentation introduced 2016-08-31 13:53 UTC by Report Bug Copy Issue Report The property `model_type` does not exist on `object<hipanel\modules\f...\models\ServerResource>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
64			}
65			}
66

hiqdev / hipanel-module-finance

Push — master ( 0edfe9...83485f )

ServerResource::getModelTypes() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like