CertificateCrudCest::ensureThatICanAddPrices() - Code Metrics - Inspection of "Merge pull request #22 from pkolomiy/request" - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b864d9...3fa98b )

by Dmitry

created 2018-08-15 12:04 UTC

CertificateCrudCest::ensureThatICanAddPrices() A

↳ Parent: CertificateCrudCest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace hipanel\modules\finance\tests\acceptance\manager;

use hipanel\helpers\Url;
use hipanel\modules\finance\tests\_support\Page\plan\Create as PlanCreatePage;
use hipanel\modules\finance\tests\_support\Page\price\certificate\Create as PriceCertificateCreate;
use hipanel\modules\finance\tests\_support\Page\price\certificate\Update as PriceCertificateUpdate;
use hipanel\tests\_support\Step\Acceptance\Manager;

class CertificateCrudCest
{
    /**
     * @var string
     */
    private $id;

    /**
     * @var array
     */
    private $fields;

    public function ensureThatICanCreateTariffPlan(Manager $I): void
    {
        $this->fields = [
            'name' => uniqid(),
            'type' => 'Certificate tariff',
            'client' => '[email protected]',
            'currency' => 'USD',
            'note' => 'test note',
        ];
        $page = new PlanCreatePage($I, $this->fields);
        $this->id = $page->createPlan();
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    public function ensureThatICanAddPrices(Manager $I)
    {
        $I->needPage(Url::to(['@plan/view', 'id' => $this->id]));
        $I->see('No prices found');
        $price = new PriceCertificateCreate($I, $this->id);
        $price->addPrices('Certificate tariff');
        $price->ensureThereNoSuggestions('Certificate tariff');
    }

    public function ensureICanUpdatePrices(Manager $I)
    {
        $price = new PriceCertificateUpdate($I, $this->id);
        $price->updatePrices();
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\tests\acceptance\manager;
4
5			use hipanel\helpers\Url;
6			use hipanel\modules\finance\tests\_support\Page\plan\Create as PlanCreatePage;
7			use hipanel\modules\finance\tests\_support\Page\price\certificate\Create as PriceCertificateCreate;
8			use hipanel\modules\finance\tests\_support\Page\price\certificate\Update as PriceCertificateUpdate;
9			use hipanel\tests\_support\Step\Acceptance\Manager;
10
11			class CertificateCrudCest
12			{
13			/**
14			* @var string
15			*/
16			private $id;
17
18			/**
19			* @var array
20			*/
21			private $fields;
22
23			public function ensureThatICanCreateTariffPlan(Manager $I): void
24			{
25			$this->fields = [
26			'name' => uniqid(),
27			'type' => 'Certificate tariff',
28			'client' => '[email protected]',
29			'currency' => 'USD',
30			'note' => 'test note',
31			];
32			$page = new PlanCreatePage($I, $this->fields);
33			$this->id = $page->createPlan();
			0 ignored issues – show Documentation Bug introduced 2018-07-24 11:22 UTC by Report Bug Copy Issue Report The property `$id` was declared of type `string`, but `$page->createPlan()` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
34			}
35
36			public function ensureThatICanAddPrices(Manager $I)
37			{
38			$I->needPage(Url::to(['@plan/view', 'id' => $this->id]));
39			$I->see('No prices found');
40			$price = new PriceCertificateCreate($I, $this->id);
41			$price->addPrices('Certificate tariff');
42			$price->ensureThereNoSuggestions('Certificate tariff');
43			}
44
45			public function ensureICanUpdatePrices(Manager $I)
46			{
47			$price = new PriceCertificateUpdate($I, $this->id);
48			$price->updatePrices();
49			}
50			}
51

hiqdev / hipanel-module-finance

Push — master ( b864d9...3fa98b )

CertificateCrudCest::ensureThatICanAddPrices() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like