Issues in PurseControllerTest.php - All Issues - Inspection of "fixed price pages layout and currecy conflicts (#1..." - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c6b5de...db50e7 )

by Dmitry

created 2019-08-02 08:04 UTC

tests/unit/controllers/PurseControllerTest.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\tests\unit\controllers;

use hipanel\modules\finance\controllers\PurseController;

/**
 * Generated by PHPUnit_SkeletonGenerator on 2016-04-27 at 13:36:04.
 */
class PurseControllerTest extends \PHPUnit\Framework\TestCase
{
    /**
     * @var PurseController
     */
    protected $object;

    protected function setUp()
    {
        $this->object = new PurseController('test', null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    protected function tearDown()
    {
    }

    public function testActions()
    {
        $this->assertInternalType('array', $this->object->actions());

    }
}


1			<?php
2			/**
3			* Finance module for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-finance
6			* @package hipanel-module-finance
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\modules\finance\tests\unit\controllers;
12
13			use hipanel\modules\finance\controllers\PurseController;
14
15			/**
16			* Generated by PHPUnit_SkeletonGenerator on 2016-04-27 at 13:36:04.
17			*/
18			class PurseControllerTest extends \PHPUnit\Framework\TestCase
19			{
20			/**
21			* @var PurseController
22			*/
23			protected $object;
24
25			protected function setUp()
26			{
27			$this->object = new PurseController('test', null);
			0 ignored issues – show Documentation introduced 2016-06-24 07:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this `null` is of type `null`, but the function expects a `object<yii\base\Module>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			}
29
30			protected function tearDown()
31			{
32			}
33
34			public function testActions()
35			{
36			$this->assertInternalType('array', $this->object->actions());
			0 ignored issues – show Deprecated Code introduced 2019-03-25 10:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `PHPUnit\Framework\Assert::assertInternalType()` has been deprecated with message: https://github.com/sebastianbergmann/phpunit/issues/3369 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
37			}
38			}
39

hiqdev / hipanel-module-finance

Push — master ( c6b5de...db50e7 )

tests/unit/controllers/PurseControllerTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like