hiqdev / hipanel-module-finance

src/forms/DomainTariffForm.php

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\forms;

use hipanel\modules\finance\logic\IntegrityException;
use hipanel\modules\finance\models\DomainResource;
use hipanel\modules\finance\models\DomainService;
use yii\web\UnprocessableEntityHttpException;

class DomainTariffForm extends AbstractTariffForm
{
    /**
     * @var array Domain zones
     * Key - zone name (com, net, ...)
     * Value - zone id
     * @see getZones
     */
    protected $zones;

    public function load($data, $formName = null)

This method seems to be duplicated in your project.

    {
        $this->setAttributes($data[$this->formName()]);
        $this->setResources($data[(new DomainResource())->formName()]);

The class hipanel\modules\finance\models\DomainResource has been deprecated with message: Is implemented in plan module

        $this->initTariff();

        return true;
    }

    /**
     * @return DomainService[]
     */
    public function getServices()
    {
        return $this->createServices($this->tariff->resources);
    }

    /**
     * @return DomainService[]
     */
    public function getParentServices()
    {
        return $this->createServices($this->parentTariff->resources);
    }

    /**
     * @param $resources
     * @return DomainService[]
     */
    protected function createServices($resources)
    {
        $result = [];
        $resource = reset($resources);

        foreach ($resource->getServiceTypes() as $type => $name) {
            $service = new DomainService([
                'name' => $name,
                'type' => $type,
            ]);

            foreach ($resources as $resource) {
                if ($service->tryResourceAssignation($resource) && $service->isFulfilled()) {
                    $result[$type] = $service;
                    break;
                }
            }
        }

        return $result;
    }

    public function setResources($resources)

This method seems to be duplicated in your project.

    {
        $result = [];
        foreach ($resources as $resource) {
            if ($resource instanceof DomainResource) {
                $result[] = $resource;
                continue;
            }

            $model = new DomainResource(['scenario' => $this->scenario]);

The class hipanel\modules\finance\models\DomainResource has been deprecated with message: Is implemented in plan module

            if ($model->load($resource, '') && $model->validate()) {
                $result[] = $model;
            } else {
                throw new UnprocessableEntityHttpException('Failed to load resource model: ' . reset($model->getFirstErrors()));

$model->getFirstErrors() cannot be passed to reset() as the parameter $array expects a reference.

            }
        }

        $this->_resources = $result;

        return $this;
    }

    public function getZoneResources($zone)

This method seems to be duplicated in your project.

    {
        $id = $this->zones[$zone];

        $result = [];

        foreach ($this->tariff->resources as $resource) {
            if (strcmp($resource->object_id, $id) === 0 && $resource->isTypeCorrect()) {
                $result[$resource->type] = $resource;
            }
        }

        if (empty($result)) {
            return [];
        }

        $types = $resource->getTypes();

The variable $resource seems to be defined by a foreach iteration on line 109. Are you sure the iterator is never empty, otherwise this variable is not defined?

        if (count($result) !== count($types)) {
            throw new IntegrityException('Found ' . count($result) . ' resources for zone "' . $zone . '". Must be exactly ' . count($types));
        }

        // sorts $result by order of $resource->getTypes()
        $result = array_merge($types, $result);

        return $result;
    }

    public function getZoneParentResources($zone)

This method seems to be duplicated in your project.

    {
        $id = $this->zones[$zone];

        $result = [];

        foreach ($this->parentTariff->resources as $resource) {
            if (strcmp($resource->object_id, $id) === 0 && $resource->isTypeCorrect()) {
                $result[$resource->type] = $resource;
            }
        }

        if (empty($result)) {
            return [];
        }

        $types = $resource->getTypes();

The variable $resource seems to be defined by a foreach iteration on line 136. Are you sure the iterator is never empty, otherwise this variable is not defined?

        if (count($result) !== count($types)) {
            throw new IntegrityException('Found ' . count($result) . ' resources for zone "' . $zone . '". Must be exactly ' . count($types));
        }

        // sorts $result by order of $resource->getTypes()
        $result = array_merge($types, $result);

        return $result;
    }

    public function getZones()
    {
        return $this->zones;
    }

    public function setZones($zones)
    {
        $this->zones = array_flip($zones);
    }
}