hipanel\modules\finance\logic\DomainTariffManager

Complexity

Total Complexity

8

Size/Duplication

Total Lines	62
Duplicated Lines	41.94 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	createForm()	0	4	1
A	insert()	14	14	2
A	update()	12	12	2
A	getZones()	0	4	1

<?php

namespace hipanel\modules\finance\logic;

use hipanel\modules\finance\forms\DomainTariffForm;
use hipanel\modules\finance\models\Tariff;
use hiqdev\hiart\ErrorResponseException;
use yii\web\NotFoundHttpException;
use yii\web\UnprocessableEntityHttpException;
use Yii;

class DomainTariffManager extends AbstractTariffManager
{
    /**
     * @var DomainTariffForm
     */
    public $form;

    /**
     * @inheritdoc
     */
    protected $type = 'domain';

    public function __construct($tariff = null)
    {
        if (!Yii::getAlias('@domain', true)) {
            throw new NotFoundHttpException('Domain module is missing');
        }

        parent::__construct($tariff);
    }

    protected function createForm($tariff = null)
    {
        $this->form = (new DomainTariffForm())->fill($this->getZones(), $this->baseTariff, $tariff);
    }

    public function insert()

This method seems to be duplicated in your project.

    {
        $data = $this->form->toArray();

        try {
            $result = Tariff::perform('Create', $data);
        } catch (ErrorResponseException $e) {
            throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
        }

        $this->form->id = $result['id'];

        return true;
    }

    public function update()

This method seems to be duplicated in your project.

    {
        $data = $this->form->toArray();

        try {
            $result = Tariff::perform('Update', $data);

$result is not used, you could remove the assignment.

        } catch (ErrorResponseException $e) {
            throw new UnprocessableEntityHttpException($e->getMessage(), 0, $e);
        }

        return true;
    }

    /**
     * @return array
     */
    protected function getZones()
    {
        return Yii::$app->hiart->get('getZones');
    }
}