RelatedPosition::__construct() - Code Metrics - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

RelatedPosition::__construct() A
last analyzed 2020-11-24 16:48 UTC

↳ Parent: RelatedPosition

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace hipanel\modules\finance\cart;

use hipanel\modules\finance\logic\Calculator;
use hipanel\modules\finance\models\CalculableModelInterface;
use hiqdev\yii2\cart\CartPositionInterface;
use hiqdev\yii2\cart\Module;
use hiqdev\yii2\cart\ShoppingCart;
use yii\base\Widget;

abstract class RelatedPosition implements RelatedPositionInterface
{
    /** @var CartPositionInterface */
    public $mainPosition;

    /** @var ShoppingCart */
    public $cart;

    /** @var CalculableModelInterface */
    public $relatedPosition;

    /** @var Widget */
    private $widget;

    public function __construct(CartPositionInterface $mainPosition)
    {
        $this->cart = Module::getInstance()->getCart();
        $this->mainPosition = $mainPosition;
        $this->relatedPosition = $this->createRelatedPosition();
        $currentPositions = $this->cart->getPositions();
        if (isset($currentPositions[$this->relatedPosition->getId()])) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $relatedPosition = $currentPositions[$this->relatedPosition->getId()];
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $this->relatedPosition = $relatedPosition;
        } else {
            $this->calculate();
        }
    }

    /** @inheritDoc */
    public function render(): string
    {
        if (!$this->widget) {
            $this->widget = $this->getWidget();
        }

        return $this->widget->run();
    }

    protected function calculate(): void
    {
        $position = $this->relatedPosition;
        $calculator = new Calculator([$position]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $calculationId = $position->getId();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $calculation = $calculator->getCalculation($calculationId);
        $value = $calculation->forCurrency($this->cart->getCurrency());
        $position->setPrice($value->price);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $position->setValue($value->value);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $position->setCurrency($value->currency);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->relatedPosition = $position;
    }
}


1			<?php
2
3			namespace hipanel\modules\finance\cart;
4
5			use hipanel\modules\finance\logic\Calculator;
6			use hipanel\modules\finance\models\CalculableModelInterface;
7			use hiqdev\yii2\cart\CartPositionInterface;
8			use hiqdev\yii2\cart\Module;
9			use hiqdev\yii2\cart\ShoppingCart;
10			use yii\base\Widget;
11
12			abstract class RelatedPosition implements RelatedPositionInterface
13			{
14			/** @var CartPositionInterface */
15			public $mainPosition;
16
17			/** @var ShoppingCart */
18			public $cart;
19
20			/** @var CalculableModelInterface */
21			public $relatedPosition;
22
23			/** @var Widget */
24			private $widget;
25
26			public function __construct(CartPositionInterface $mainPosition)
27			{
28			$this->cart = Module::getInstance()->getCart();
29			$this->mainPosition = $mainPosition;
30			$this->relatedPosition = $this->createRelatedPosition();
31			$currentPositions = $this->cart->getPositions();
32			if (isset($currentPositions[$this->relatedPosition->getId()])) {
			0 ignored issues – show Bug introduced 2020-03-24 14:59 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `hipanel\modules\finance\...alculableModelInterface` as the method `getId()` does only exist in the following implementations of said interface: `hipanel\modules\finance\cart\AbstractCartPosition`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
33			$relatedPosition = $currentPositions[$this->relatedPosition->getId()];
			0 ignored issues – show Bug introduced 2020-03-24 14:59 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `hipanel\modules\finance\...alculableModelInterface` as the method `getId()` does only exist in the following implementations of said interface: `hipanel\modules\finance\cart\AbstractCartPosition`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
34			$this->relatedPosition = $relatedPosition;
35			} else {
36			$this->calculate();
37			}
38			}
39
40			/** @inheritDoc */
41			public function render(): string
42			{
43			if (!$this->widget) {
44			$this->widget = $this->getWidget();
45			}
46
47			return $this->widget->run();
48			}
49
50			protected function calculate(): void
51			{
52			$position = $this->relatedPosition;
53			$calculator = new Calculator([$position]);
			0 ignored issues – show Documentation introduced 2020-03-19 15:34 UTC by Report Bug Copy Issue Report `array($position)` is of type `array<integer,object<hip...lableModelInterface>"}>`, but the function expects a `array<integer,object<yii\base\Model>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			$calculationId = $position->getId();
			0 ignored issues – show Bug introduced 2020-03-24 14:59 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `hipanel\modules\finance\...alculableModelInterface` as the method `getId()` does only exist in the following implementations of said interface: `hipanel\modules\finance\cart\AbstractCartPosition`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
55			$calculation = $calculator->getCalculation($calculationId);
56			$value = $calculation->forCurrency($this->cart->getCurrency());
57			$position->setPrice($value->price);
			0 ignored issues – show Bug introduced 2020-03-19 15:34 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `hipanel\modules\finance\...alculableModelInterface` as the method `setPrice()` does only exist in the following implementations of said interface: `hipanel\modules\finance\cart\AbstractCartPosition`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
58			$position->setValue($value->value);
			0 ignored issues – show Bug introduced 2020-03-19 15:34 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `hipanel\modules\finance\...alculableModelInterface` as the method `setValue()` does only exist in the following implementations of said interface: `hipanel\modules\finance\cart\AbstractCartPosition`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
59			$position->setCurrency($value->currency);
			0 ignored issues – show Bug introduced 2020-03-19 15:34 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `hipanel\modules\finance\...alculableModelInterface` as the method `setCurrency()` does only exist in the following implementations of said interface: `hipanel\modules\finance\cart\AbstractCartPosition`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
60			$this->relatedPosition = $position;
61			}
62			}
63

hiqdev / hipanel-module-finance

RelatedPosition::__construct() A last analyzed 2020-11-24 16:48 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RelatedPosition::__construct() A
last analyzed 2020-11-24 16:48 UTC