TemplatePricePresenter - Code Metrics - hiqdev/hipanel-module-finance - Measure and Improve Code Quality continuously with Scrutinizer

TemplatePricePresenter A
last analyzed 2020-11-24 16:48 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	4
dl	0
loc	37
ccs	0
cts	19
cp	0
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	renderPrice()	0	30	6

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\grid\presenters\price;

use hipanel\helpers\StringHelper;
use hipanel\modules\finance\models\Price;
use Yii;
use yii\base\InvalidConfigException;
use yii\helpers\Html;

/**
 * Class TemplatePricePresenter.
 *
 * @author Dmytro Naumenko <[email protected]>
 */
class TemplatePricePresenter extends PricePresenter
{
    /**
     * @param \hipanel\modules\finance\models\TemplatePrice $price
     * @return string
     */
    public function renderPrice(Price $price): string
    {
        $formatter = Yii::$app->formatter;

        $unit = '';
        if ($price->getUnitLabel()) {
            $unit = ' ' . Yii::t('hipanel:finance', 'per {unit}', ['unit' => $price->getUnitLabel()]);
        }

        if (StringHelper::startsWith($price->type, 'referral')) {
            $result = [
                Html::tag('strong', $price->rate . '%'),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ];
        } else {
            $result = [
                Html::tag('strong', $formatter->asCurrency($price->price, $price->currency) . $unit),
            ];
        }
        if ($price->subprices) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            foreach ($price->subprices as $currencyCode => $amount) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                try {
                    $result[] = $formatter->asCurrency($amount, $currencyCode);
                } catch (InvalidConfigException $e) {
                    $result[] = $amount . ' ' . $currencyCode;
                }
            }
        }

        return implode('&nbsp;&mdash;&nbsp;', $result);
    }
}


1			<?php
2			/**
3			* Finance module for HiPanel
4			*
5			* @link https://github.com/hiqdev/hipanel-module-finance
6			* @package hipanel-module-finance
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hipanel\modules\finance\grid\presenters\price;
12
13			use hipanel\helpers\StringHelper;
14			use hipanel\modules\finance\models\Price;
15			use Yii;
16			use yii\base\InvalidConfigException;
17			use yii\helpers\Html;
18
19			/**
20			* Class TemplatePricePresenter.
21			*
22			* @author Dmytro Naumenko <[email protected]>
23			*/
24			class TemplatePricePresenter extends PricePresenter
25			{
26			/**
27			* @param \hipanel\modules\finance\models\TemplatePrice $price
28			* @return string
29			*/
30			public function renderPrice(Price $price): string
31			{
32			$formatter = Yii::$app->formatter;
33
34			$unit = '';
35			if ($price->getUnitLabel()) {
36			$unit = ' ' . Yii::t('hipanel:finance', 'per {unit}', ['unit' => $price->getUnitLabel()]);
37			}
38
39			if (StringHelper::startsWith($price->type, 'referral')) {
40			$result = [
41			Html::tag('strong', $price->rate . '%'),
			0 ignored issues – show Documentation introduced 2020-07-31 13:25 UTC by Report Bug Copy Issue Report The property `rate` does not exist on `object<hipanel\modules\finance\models\Price>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
42			];
43			} else {
44			$result = [
45			Html::tag('strong', $formatter->asCurrency($price->price, $price->currency) . $unit),
46			];
47			}
48			if ($price->subprices) {
			0 ignored issues – show Documentation introduced 2020-07-29 14:21 UTC by Report Bug Copy Issue Report The property `subprices` does not exist on `object<hipanel\modules\finance\models\Price>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
49			foreach ($price->subprices as $currencyCode => $amount) {
			0 ignored issues – show Documentation introduced 2018-06-27 11:41 UTC by Report Bug Copy Issue Report The property `subprices` does not exist on `object<hipanel\modules\finance\models\Price>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
50			try {
51			$result[] = $formatter->asCurrency($amount, $currencyCode);
52			} catch (InvalidConfigException $e) {
53			$result[] = $amount . ' ' . $currencyCode;
54			}
55			}
56			}
57
58			return implode(' — ', $result);
59			}
60			}
61

hiqdev / hipanel-module-finance

TemplatePricePresenter A last analyzed 2020-11-24 16:48 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like

TemplatePricePresenter A
last analyzed 2020-11-24 16:48 UTC