hipanel\modules\finance\forms\CertificateTariffForm

Complexity

Total Complexity

23

Size/Duplication

Total Lines	131
Duplicated Lines	6.87 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	load()	9	9	1
A	getPeriods()	0	4	1
A	setResources()	0	11	2
A	createResource()	0	13	5
A	getCertificateTypes()	0	12	3
A	getCertificateTypeId()	0	4	1
A	getTypeResources()	0	4	1
A	setCertificateTypes()	0	4	1
A	getTypeParentResources()	0	4	1
B	extractResources()	0	31	6

<?php
/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\forms;

use hipanel\modules\finance\logic\IntegrityException;
use hipanel\modules\finance\models\CertificateResource;
use yii\web\UnprocessableEntityHttpException;

/**
 * Class CertificateTariffForm.
 *
 * @author Dmytro Naumenko <d.naumenko.a@gmail.com>
 */
class CertificateTariffForm extends AbstractTariffForm
{
    protected $certificateTypes = [];

    public function __construct(array $config = [])
    {
        parent::__construct($config);
    }

    public function load($data, $formName = null)

This method seems to be duplicated in your project.

    {
        $this->setAttributes($data[$this->formName()]);
        $this->setResources($data[(new CertificateResource())->formName()]);

The class hipanel\modules\finance\models\CertificateResource has been deprecated with message: Is implemented in plan module

        $this->initTariff();

        return true;
    }

    /**
     * @return array
     */
    public static function getPeriods()
    {
        return CertificateResource::getPeriods();
    }

    public function setResources($resources)
    {
        $result = [];
        foreach ($resources as $resource) {
            $result[] = $this->createResource($resource);
        }

        $this->_resources = $result;

        return $this;
    }

    protected function createResource($resource)
    {
        if ($resource instanceof CertificateResource) {
            return $resource;
        }

        $model = new CertificateResource(['scenario' => $this->scenario ?: 'default']);

The class hipanel\modules\finance\models\CertificateResource has been deprecated with message: Is implemented in plan module

        if ($model->load($resource, '') && $model->validate()) {
            return $model;
        } else {
            throw new UnprocessableEntityHttpException('Failed to load resource model: ' . reset($model->getFirstErrors()));

$model->getFirstErrors() cannot be passed to reset() as the parameter $array expects a reference.

        }
    }

    public function getCertificateTypes()
    {
        $result = [];

        foreach ($this->tariff->resources as $resource) {
            if (isset($this->certificateTypes[$resource->object_id])) {
                $result[$resource->object_id] = $this->certificateTypes[$resource->object_id];
            }
        }

        return $result;
    }

    protected function getCertificateTypeId($type)
    {
        return array_search($type, $this->certificateTypes, true);
    }

    /**
     * @param $type
     * @throws IntegrityException
     * @return CertificateResource[]
     */
    public function getTypeResources($type)
    {
        return $this->extractResources($type, $this->tariff->resources);
    }

    /**
     * @param array $certificateTypes
     */
    public function setCertificateTypes($certificateTypes)
    {
        $this->certificateTypes = $certificateTypes;
    }

    /**
     * @param $type
     * @throws IntegrityException
     * @return CertificateResource[]
     */
    public function getTypeParentResources($type)
    {
        return $this->extractResources($type, $this->parentTariff->resources);
    }

    protected function extractResources($certificateType, $resources)
    {
        $id = $this->getCertificateTypeId($certificateType);

        $tmpres = [];

        foreach ($resources as $resource) {
            if (strcmp($resource->object_id, $id) === 0 && $resource->isTypeCorrect()) {
                $tmpres[$resource->type] = $resource;
            }
        }

        $types = $resource->getTypes();

The variable $resource seems to be defined by a foreach iteration on line 127. Are you sure the iterator is never empty, otherwise this variable is not defined?

        /* XXX why die? let's try with empty resource
         * if (count($tmpres) !== count($types)) {
            throw new IntegrityException('Found ' . count($tmpres) . ' resources for certificate "' . $type . '". Must be exactly ' . count($types));
        }

        // sorts $tmpres by order of $resource->getTypes()
        $tmpres = array_merge($types, $tmpres);
         */

        foreach (array_keys($types) as $type) {
            $res[$type] = isset($tmpres[$type]) ? $tmpres[$type] : $this->createResource([

$res was never initialized. Although not strictly required by PHP, it is generally a good practice to add $res = array(); before regardless.

                'object_id' => $id,
                'type' => $type,
            ]);
        }

        return $res;

The variable $res does not seem to be defined for all execution paths leading up to this point.

    }
}