hipanel\modules\finance\controllers\ChargeController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	behaviors()	0	11	1
A	actions()	0	18	1
A	getTypesAndGroups()	0	4	1

<?php

/**
 * Finance module for HiPanel
 *
 * @link      https://github.com/hiqdev/hipanel-module-finance
 * @package   hipanel-module-finance
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2019, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\modules\finance\controllers;

use hipanel\actions\IndexAction;
use hipanel\actions\RenderAction;
use hipanel\base\CrudController;
use hipanel\filters\EasyAccessControl;
use hipanel\modules\finance\models\query\ChargeQuery;
use hipanel\modules\finance\providers\BillTypesProvider;
use yii\base\Event;

/**
 * Class ChargeController
 * @package hipanel\modules\finance\controllers
 */
class ChargeController extends CrudController
{
    /**
     * @var BillTypesProvider
     */
    private $billTypesProvider;

    public function __construct($id, $module, BillTypesProvider $billTypesProvider, $config = [])
    {
        parent::__construct($id, $module, $config);

        $this->billTypesProvider = $billTypesProvider;
    }

    /**
     * @inheritDoc
     */
    public function behaviors()
    {
        return array_merge(parent::behaviors(), [

The return type of return array_merge(parent::behaviors(), array('access-bill' => array('class' => \hipanel\filters\EasyAccessControl::class, 'actions' => array('*' => 'bill.charges.read')))); (array<*,array>) is incompatible with the return type of the parent method hipanel\base\Controller::behaviors of type array[].

            'access-bill' => [
                'class' => EasyAccessControl::class,
                'actions' => [
                    '*' => 'bill.charges.read',
                ],
            ],
        ]);
    }

    /**
     * @inheritDoc
     */
    public function actions()
    {
        return array_merge(parent::actions(), [
            'index' => [
                'class' => IndexAction::class,
                'on beforePerform' => function (Event $event) {
                    /** @var ChargeQuery $query */
                    $query = $event->sender->getDataProvider()->query;
                    $query->withCommonObject()->withLatestCommonObject();
                },
                'data' => function (RenderAction $action, array $data): array {

The parameter $action is not used and could be removed.

The parameter $data is not used and could be removed.

                    [$billTypes, $billGroupLabels] = $this->getTypesAndGroups();

The variable $billTypes does not exist. Did you forget to declare it?

The variable $billGroupLabels does not exist. Did you forget to declare it?

                    return compact('billTypes', 'billGroupLabels');
                },
            ],
        ]);
    }

    /**
     * @return array
     */
    private function getTypesAndGroups()
    {
        return $this->billTypesProvider->getGroupedList();
    }
}