hipanel\controllers\ReminderController::actions()

Complexity

Conditions	4
Paths	1

Size

Total Lines	78
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	8
Bugs	0	Features	4

<?php
    public function actions()
    {
        return [
            'set-orientation' => [
                'class' => OrientationAction::class,
                'allowedRoutes' => [
                    'reminder/index'
                ]
            ],
            'validate-form' => [
                'class' => ValidateFormAction::class,
            ],
            'view' => [
                'class' => ViewAction::class,
            ],
            'index' => [
                'class' => IndexAction::class,
                'data' => function ($action, $data) {

The parameter $action is not used and could be removed.

The parameter $data is not used and could be removed.

                    return [

                    ];
                },
            ],
            'create-modal' => [
                'class' => SmartCreateAction::class,
                'scenario' => 'create',
                'view' => 'create-modal',
                'data' => function ($action, $data) {
                    $object_id = \Yii::$app->request->get('object_id');
                    if (empty($object_id)) {
                        throw new NotFoundHttpException('Object ID is missing');
                    }
                    $data['model']->object_id = $object_id;

                    return $data;
                },
            ],
            'create' => [
                'class' => SmartCreateAction::class,
                'view' => 'create-modal',
            ],
            'update' => [
                'class' => SmartUpdateAction::class,
                'on beforeSave' => function ($event) {
                    /** @var \hipanel\actions\Action $action */
                    $action = $event->sender;
                    if (Yii::$app->request->isAjax) {
                        $reminder = Yii::$app->request->post('Reminder');
                        $action->collection->set(Reminder::find()->where(['id' => $reminder['id']])->one());

It seems like \hipanel\models\Reminder::find()->where(array('id' => $reminder['id']))->one() targeting hiqdev\hiart\ActiveQuery::one() can also be of type null; however, hiqdev\hiart\Collection::set() does only seem to accept array|object<hiqdev\hiart\ActiveRecord>, maybe add an additional type check?

                        foreach ($action->collection->models as $model) {
                            $model->next_time = (new DateTime($model->next_time))->modify($reminder['next_time'])->format('Y-m-d H:i:s');
                        }
                    }
                },
                'POST ajax' => [
                    'save' => true,
                    'success' => [
                        'class' => RenderJsonAction::class,
                        'return' => function ($action) {

The parameter $action is not used and could be removed.

                            return [
                                'success' => true,
                                'widget' => ReminderTop::widget()
                            ]; // todo: wise resulting
                        },
                    ],
                ],
            ],
            'delete' => [
                'class' => SmartDeleteAction::class,
                'POST html | POST pjax' => [
                    'save' => true,
                    'success' => [
                        'class' => RedirectAction::class,
                    ],
                ],
            ]
        ];
    }