hipanel\models\IndexPageUiOptions

Complexity

Total Complexity

6

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	fields()	0	4	1
A	rules()	0	14	1
A	getOrientationOptions()	0	7	1
A	getDefaultOrientation()	0	11	3

<?php

namespace hipanel\models;

use Yii;
use yii\base\Model;

class IndexPageUiOptions extends Model
{
    public $sort;

    public $per_page;

    public $orientation;

    public $representation;

    public $representationOptions = [];

    public function fields()
    {
        return ['sort', 'per_page', 'orientation', 'representation'];
    }

    public function rules()
    {
        return [
            ['per_page', 'default', 'value' => 25],
            ['per_page', 'number', 'skipOnEmpty' => true],

            ['sort', 'string', 'skipOnEmpty' => true],

            ['orientation', 'default', 'value' => $this->getDefaultOrientation()],
            ['orientation', 'in', 'range' => array_keys($this->getOrientationOptions())],

            ['representation', 'in', 'range' => $this->representationOptions, 'skipOnEmpty' => true],
        ];
    }

    /**
     * @return array
     */
    public function getOrientationOptions()
    {
        return [
            'horizontal' => Yii::t('hipanel', 'Horizontal'),
            'vertical' => Yii::t('hipanel', 'Vertical'),
        ];
    }

    /**
     * @return string
     */
    public function getDefaultOrientation()
    {
        $settings = Yii::$app->themeManager->getSettings();
        $orientationOptions = array_keys($this->getOrientationOptions());

        if (property_exists($settings, 'filterOrientation') && in_array($settings->filterOrientation, $orientationOptions, true)) {
            return $settings->filterOrientation;
        } else {
            return reset($orientationOptions);

The expression reset($orientationOptions); of type string|false adds false to the return on line 62 which is incompatible with the return type documented by hipanel\models\IndexPageUiOptions::getDefaultOrientation of type string. It seems like you forgot to handle an error condition.

        }
    }
}