Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | class Connection extends \hiqdev\hiart\Connection |
||
17 | { |
||
18 | /** |
||
19 | * @param mixed $response The response |
||
20 | * @return null|string |
||
21 | * - string: the error text |
||
22 | * - null: the response is not an error |
||
23 | */ |
||
24 | public function checkError($response) |
||
41 | |||
42 | /** |
||
43 | * Prepares authorization data. |
||
44 | * If user is not authorized redirects to authorization. |
||
45 | * @return array |
||
46 | */ |
||
47 | public function getAuth() |
||
79 | } |
||
80 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.