Completed
Push — master ( 95699a...6ff7db )
by Dmitry
03:54
created

SettingsStorage   A

Complexity

Total Complexity 10

Size/Duplication

Total Lines 84
Duplicated Lines 40.48 %

Coupling/Cohesion

Components 1
Dependencies 5

Test Coverage

Coverage 0%

Importance

Changes 2
Bugs 0 Features 0
Metric Value
wmc 10
c 2
b 0
f 0
lcom 1
cbo 5
dl 34
loc 84
ccs 0
cts 48
cp 0
rs 10

7 Methods

Rating   Name   Duplication   Size   Complexity  
A init() 0 4 1
A setGlobal() 8 8 1
A setBounded() 8 8 1
A getGlobal() 9 9 1
A getBounded() 9 9 1
A perform() 0 8 2
A decodeResponse() 0 5 3

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace hipanel\components;
4
5
use hiqdev\hiart\Connection;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, hipanel\components\Connection.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
use yii\base\Component;
7
use yii\di\Instance;
8
use Yii;
9
10
class SettingsStorage extends Component implements SettingsStorageInterface
11
{
12
    /**
13
     * @var Connection
14
     */
15
    private $connection;
16
17
    public function init()
18
    {
19
        $this->connection = Instance::ensure('hiart', Connection::class);
20
    }
21
22
    /**
23
     * @inheritdoc
24
     */
25 View Code Duplication
    public function setGlobal($key, $value)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
26
    {
27
        $this->perform('clientSetSettingsStorage', array_merge([
28
            'key' => $key,
29
            'data' => json_encode($value),
30
            'oauthClientBound' => false
31
        ]));
32
    }
33
34
    /**
35
     * @inheritdoc
36
     */
37 View Code Duplication
    public function setBounded($key, $value)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
38
    {
39
        $this->perform('clientSetSettingsStorage', array_merge([
40
            'key' => $key,
41
            'data' => json_encode($value),
42
            'oauthClientBound' => true
43
        ]));
44
    }
45
46
    /**
47
     * @inheritdoc
48
     */
49 View Code Duplication
    public function getGlobal($key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
50
    {
51
        $response = $this->perform('clientGetSettingsStorage', array_merge([
52
            'key' => $key,
53
            'oauthClientBound' => false
54
        ]));
55
56
        return $this->decodeResponse($response);
57
    }
58
59
    /**
60
     * @inheritdoc
61
     */
62 View Code Duplication
    public function getBounded($key)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
63
    {
64
        $response = $this->perform('clientGetSettingsStorage', array_merge([
65
            'key' => $key,
66
            'oauthClientBound' => true
67
        ]));
68
69
        return $this->decodeResponse($response);
70
    }
71
72
    /**
73
     * Performs request to the API
74
     *
75
     * @param string $key
76
     * @param array $value
77
     * @return array
78
     */
79
    private function perform($key, $value)
80
    {
81
        if (Yii::$app->user->isGuest) {
82
            return [];
83
        }
84
85
        return $this->connection->createCommand()->perform($key, $value);
86
    }
87
88
    private function decodeResponse($response)
89
    {
90
        $result = json_decode(isset($response['data']) ? $response['data'] : '{}', true);
91
        return $result === null ? [] : $result;
92
    }
93
}
94