UserMenu::items() - Code Metrics - Inspection of "+ AbstractDetailMenu" - hiqdev/hipanel-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 51e253...53c186 )

by Andrii

created 2016-12-21 13:35 UTC

UserMenu::items() B

↳ Parent: UserMenu

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	26
ccs	0
cts	23
cp	0
rs	8.8571
cc	1
eloc	17
nc	1
nop	0
crap	2

<?php

namespace hipanel\menus;

use hiqdev\thememanager\widgets\UserMenu as UserMenuWidget;
use Yii;

class UserMenu extends \hiqdev\menumanager\Menu
{
    public function widget($options = [])
    {
        $defaultOptions = [
            'class' => UserMenuWidget::class,
            'options' => ['class' => 'sidebar-menu'],
        ];

        return parent::widget(array_merge($defaultOptions, $options));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    public function items()
    {
        return [
            'header' => [
                'label' => $this->render('userMenuHeader'),
            ],
            'profile' => [
                'label' => Yii::t('hipanel', 'Profile'),
                'url'   => ['/site/profile'],
            ],
            'logout' => [
                'label' => Yii::t('hipanel', 'Sign out'),
                'url'   => ['/site/logout'],
            ],

            'deposit' => [
                'label' => Yii::t('hipanel', 'Recharge account'),
                'url'   => ['@pay/deposit'],
                'visible' => Yii::$app->user->can('deposit'),
            ],
            'ticket' => [
                'label' => Yii::t('hipanel', 'Create ticket'),
                'url'   => ['@ticket/create'],
            ],
        ];
    }
}


1			<?php
2
3			namespace hipanel\menus;
4
5			use hiqdev\thememanager\widgets\UserMenu as UserMenuWidget;
6			use Yii;
7
8			class UserMenu extends \hiqdev\menumanager\Menu
9			{
10			public function widget($options = [])
11			{
12			$defaultOptions = [
13			'class' => UserMenuWidget::class,
14			'options' => ['class' => 'sidebar-menu'],
15			];
16
17			return parent::widget(array_merge($defaultOptions, $options));
			0 ignored issues – show Bug introduced 2016-12-21 13:40 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `hiqdev\menumanager\Menu` as the method `widget()` does only exist in the following sub-classes of `hiqdev\menumanager\Menu`: `hipanel\menus\SidebarMenu`, `hipanel\menus\UserMenu`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
18			}
19
20			public function items()
21			{
22			return [
23			'header' => [
24			'label' => $this->render('userMenuHeader'),
25			],
26			'profile' => [
27			'label' => Yii::t('hipanel', 'Profile'),
28			'url' => ['/site/profile'],
29			],
30			'logout' => [
31			'label' => Yii::t('hipanel', 'Sign out'),
32			'url' => ['/site/logout'],
33			],
34
35			'deposit' => [
36			'label' => Yii::t('hipanel', 'Recharge account'),
37			'url' => ['@pay/deposit'],
38			'visible' => Yii::$app->user->can('deposit'),
39			],
40			'ticket' => [
41			'label' => Yii::t('hipanel', 'Create ticket'),
42			'url' => ['@ticket/create'],
43			],
44			];
45			}
46			}
47

hiqdev / hipanel-core

Push — master ( 51e253...53c186 )

UserMenu::items() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like