File::saveUploadedFile() - Code Metrics - Inspection of "Translations updated" - hiqdev/hipanel-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 47e90b...cbd9f9 )

by Dmitry

created 2016-07-18 16:57 UTC

File::saveUploadedFile() A

↳ Parent: File

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	4
eloc	9
c	3
b	0
f	0
nc	3
nop	1
dl	0
loc	14
ccs	0
cts	13
cp	0
crap	20
rs	9.2

<?php

/*
 * HiPanel core package
 *
 * @link      https://hipanel.com/
 * @package   hipanel-core
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2014-2016, HiQDev (http://hiqdev.com/)
 */

/**
 * Created by PhpStorm.
 * User: tofid
 * Date: 11.02.15
 * Time: 17:59.
 */
namespace hipanel\behaviors;

use hipanel\models\File as FileModel;
use yii\base\Behavior;
use yii\db\BaseActiveRecord;
use yii\helpers\FileHelper;
use yii\web\UploadedFile;

class File extends Behavior
{
    /**
     * @var string the attribute which holds the attachment.
     */
    public $attribute = 'file';

    /**
     * @var array the scenarios in which the behavior will be triggered
     */
    public $scenarios = [];

    /**
     * @var string the attribute that will receive the file id
     */
    public $savedAttribute;

    /**
     * @var UploadedFile the uploaded file instance.
     */
    private $_file;

    /**
     * @return array
     */
    public function events()
    {
        return [
            BaseActiveRecord::EVENT_BEFORE_INSERT => 'saveUploadedFile',
            BaseActiveRecord::EVENT_BEFORE_UPDATE => 'saveUploadedFile',
        ];
    }

    /**
     * Event handler for beforeSave.
     * @param \yii\base\ModelEvent|boolean $event
     */
    public function saveUploadedFile($event)

    {
        $model = $this->owner;
        $arr_ids = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (in_array($model->scenario, $this->scenarios, true)) {
            $this->_file = UploadedFile::getInstances($model, $this->attribute);

            if (is_array($this->_file) && !empty($this->_file)) {
                $this->owner->{$this->savedAttribute} = implode(',', FileModel::fileSave($this->_file));
            } else {
                // Protect attribute
                unset($model->{$this->attribute});
            }
        }
    }
}


1			<?php
2
3			/*
4			* HiPanel core package
5			*
6			* @link https://hipanel.com/
7			* @package hipanel-core
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2014-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			/**
13			* Created by PhpStorm.
14			* User: tofid
15			* Date: 11.02.15
16			* Time: 17:59.
17			*/
18			namespace hipanel\behaviors;
19
20			use hipanel\models\File as FileModel;
21			use yii\base\Behavior;
22			use yii\db\BaseActiveRecord;
23			use yii\helpers\FileHelper;
24			use yii\web\UploadedFile;
25
26			class File extends Behavior
27			{
28			/**
29			* @var string the attribute which holds the attachment.
30			*/
31			public $attribute = 'file';
32
33			/**
34			* @var array the scenarios in which the behavior will be triggered
35			*/
36			public $scenarios = [];
37
38			/**
39			* @var string the attribute that will receive the file id
40			*/
41			public $savedAttribute;
42
43			/**
44			* @var UploadedFile the uploaded file instance.
45			*/
46			private $_file;
47
48			/**
49			* @return array
50			*/
51			public function events()
52			{
53			return [
54			BaseActiveRecord::EVENT_BEFORE_INSERT => 'saveUploadedFile',
55			BaseActiveRecord::EVENT_BEFORE_UPDATE => 'saveUploadedFile',
56			];
57			}
58
59			/**
60			* Event handler for beforeSave.
61			* @param \yii\base\ModelEvent\|boolean $event
62			*/
63			public function saveUploadedFile($event)
			0 ignored issues – show Unused Code introduced 2016-03-31 13:05 UTC by Report Bug Copy Issue Report The parameter `$event` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
64			{
65			$model = $this->owner;
66			$arr_ids = [];
			0 ignored issues – show Unused Code introduced 2016-03-31 13:05 UTC by Report Bug Copy Issue Report `$arr_ids` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
67			if (in_array($model->scenario, $this->scenarios, true)) {
68			$this->_file = UploadedFile::getInstances($model, $this->attribute);
			0 ignored issues – show Compatibility introduced 2016-03-31 13:05 UTC by Report Bug Copy Issue Report `$model` of type `object<yii\base\Component>` is not a sub-type of `object<yii\base\Model>`. It seems like you assume a child class of the class `yii\base\Component` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Documentation Bug introduced 2016-03-31 13:05 UTC by Report Bug Copy Issue Report It seems like `\yii\web\UploadedFile::g...odel, $this->attribute)` of type `array<integer,object<yii\web\UploadedFile>>` is incompatible with the declared type `object<yii\web\UploadedFile>` of property `$_file`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
69			if (is_array($this->_file) && !empty($this->_file)) {
70			$this->owner->{$this->savedAttribute} = implode(',', FileModel::fileSave($this->_file));
71			} else {
72			// Protect attribute
73			unset($model->{$this->attribute});
74			}
75			}
76			}
77			}
78

hiqdev / hipanel-core

Push — master ( 47e90b...cbd9f9 )

File::saveUploadedFile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like