hipanel\components\User

Complexity

Total Complexity

11

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	1	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	7	2
A	not()	0	9	2
A	is()	0	9	2
A	getIsGuest()	0	4	1
B	getAuthData()	0	23	4

<?php

/*
 * HiPanel core package
 *
 * @link      https://hipanel.com/
 * @package   hipanel-core
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2014-2016, HiQDev (http://hiqdev.com/)
 */

namespace hipanel\components;

use Yii;
use yii\base\InvalidCallException;
use yii\base\InvalidConfigException;

class User extends \yii\web\User
{
    public $isGuestAllowed = false;

    /**
     * @var string the seller login
     */
    public $seller;

    public function init()
    {
        parent::init();
        if (empty($this->seller)) {
            throw new InvalidConfigException('User "seller" must be set');
        }
    }

    public function not($key)
    {
        $identity = $this->getIdentity();
        if (!$identity) {

The expression $identity of type null|boolean is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            throw new InvalidCallException();
        }

        return $identity->not($key);

The method not cannot be called on $identity (of type boolean).

    }

    public function is($key)
    {
        $identity = $this->getIdentity();
        if (!$identity) {

The expression $identity of type null|boolean is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            throw new InvalidCallException();
        }

        return $identity->is($key);

The method is cannot be called on $identity (of type boolean).

    }
    /**
     * @inheritdoc
     * XXX fixes redirect loop when identity is set but the object is empty
     * @return bool
     */
    public function getIsGuest()
    {
        return empty($this->getIdentity()->id);
    }

    /**
     * Prepares authorization data.
     * Redirects to authorization if necessary.
     * @return array
     */
    public function getAuthData()
    {
        if ($this->isGuest) {
            if ($this->isGuestAllowed) {
                return [];
            } else {
                Yii::$app->response->redirect('/site/login');
                Yii::$app->end();
            }
        }

        $token = $this->identity->getAccessToken();

It seems like you code against a concrete implementation and not the interface yii\web\IdentityInterface as the method getAccessToken() does only exist in the following implementations of said interface: hipanel\models\User.

        if (empty($token)) {
            /// this is very important line
            /// without this line - redirect loop
            $this->logout();

            Yii::$app->response->redirect('/site/login');
            Yii::$app->end();
        }

        return ['access_token' => $token];
    }
}