hipanel\tests\_support\Page\Widget\Input\Dropdown

Complexity

Total Complexity

4

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	withItems()	0	4	1
A	isVisible()	0	9	3

<?php

namespace hipanel\tests\_support\Page\Widget\Input;

use hipanel\tests\_support\AcceptanceTester;

class Dropdown extends TestableInput
{
    /**
     * @property string[]|null
     */
    private $items;

    /**
     * @param string[] $items array of items names
     */
    public function withItems(array $items): void
    {
        $this->items = $items;
    }

    public function isVisible(AcceptanceTester $I, string $formId): void
    {
        $I->seeElement("//form[@id='$formId']//select", ['id' => $this->name]);
        if ($this->items) {

The expression $this->items of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->items as $item) {
                $I->see($item, "//form[@id='$formId']//select[@id='$this->name']/option");
            }
        }
    }
}