Interpolator::get() - Code Metrics - Inspection of "fixed buildConfigPath, removed use of `Builder::pa..." - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2a3256...770069 )

by Andrii

created 2017-04-19 12:25 UTC

Interpolator::get() A

↳ Parent: Interpolator

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
dl	0
loc	12
ccs	0
cts	7
cp	0
rs	9.2
c	2
b	0
f	2
cc	4
eloc	9
nc	4
nop	2
crap	20

<?php

namespace hidev\components;

use Yii;
use yii\helpers\ArrayHelper;

class Interpolator
{
    public function interpolate(&$data)
    {
        if (is_array($data)) {
            foreach ($data as &$item) {
                $this->interpolate($item);
            }
        } elseif (is_string($data)) {
            $data = preg_replace_callback('/\\$(\\w+)\\[\'(.+?)\'\\]/', function ($matches) {
                return $this->get($matches[1], $matches[2]);
            }, $data);
        }
    }

    public function get($scope, $name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($scope === 'params') {
            return Yii::$app->params[$name];
        } elseif ($scope === '_ENV') {
            return $_ENV[$name];
        } elseif ($scope === 'config') {
            return $this->getConfig($name);
        } else {
            return "\$${scope}['$name']";
        }
    }

    public function getConfig($name)
    {
        list($goal, $subname) = explode('.', $name, 2);

        return ArrayHelper::getValue(Yii::$app->get('config')->getGoal($goal), $subname);
    }
}


1			<?php
2
3			namespace hidev\components;
4
5			use Yii;
6			use yii\helpers\ArrayHelper;
7
8			class Interpolator
9			{
10			public function interpolate(&$data)
11			{
12			if (is_array($data)) {
13			foreach ($data as &$item) {
14			$this->interpolate($item);
15			}
16			} elseif (is_string($data)) {
17			$data = preg_replace_callback('/\\$(\\w+)\\[\'(.+?)\'\\]/', function ($matches) {
18			return $this->get($matches[1], $matches[2]);
19			}, $data);
20			}
21			}
22
23			public function get($scope, $name)
			0 ignored issues – show Coding Style introduced 2017-04-18 16:28 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_ENV` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
24			{
25			if ($scope === 'params') {
26			return Yii::$app->params[$name];
27			} elseif ($scope === '_ENV') {
28			return $_ENV[$name];
29			} elseif ($scope === 'config') {
30			return $this->getConfig($name);
31			} else {
32			return "\$${scope}['$name']";
33			}
34			}
35
36			public function getConfig($name)
37			{
38			list($goal, $subname) = explode('.', $name, 2);
39
40			return ArrayHelper::getValue(Yii::$app->get('config')->getGoal($goal), $subname);
41			}
42			}
43

hiqdev / hidev

Push — master ( 2a3256...770069 )

Interpolator::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like