GitHubGoal::actionClone() - Code Metrics - Inspection of "fixed typo" - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 826e4e...164599 )

by Andrii

created 2015-12-26 17:16 UTC

GitHubGoal::actionClone() A

↳ Parent: GitHubGoal

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

/*
 * Task runner, code generator and build tool for easier continuos integration
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2014-2015, HiQDev (http://hiqdev.com/)
 */

namespace hidev\goals;

/**
 * Goal for GitHub.
 */
class GitHubGoal extends DefaultGoal
{
    public function setName($value)
    {
        list($vendor, $package) = explode('/', $value, 2);
        $this->setItem('name',    $value);
        $this->setItem('vendor',  $vendor ?: $package);
        $this->setItem('package', $package ?: $vendor);
    }

    public function getName()
    {
        return $this->getItem('name') ?: $this->config->package->fullName;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getPackage()
    {
        return $this->getItem('package') ?: $this->config->package->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getVendor()
    {
        return $this->getItem('vendor') ?: $this->config->vendor->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function actionCreate()
    {
    }

    /**
     * Clone repo from github.
     * TODO to work need to redo HiDev to run this action without normal initilization.
     * @param string $repo full name vendor/package
     * @return int exit code
     */
    public function actionClone($repo)
    {
        return $this->passthru('git', ['clone', '[email protected]:' . $repo]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			/*
4			* Task runner, code generator and build tool for easier continuos integration
5			*
6			* @link https://github.com/hiqdev/hidev
7			* @package hidev
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2014-2015, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hidev\goals;
13
14			/**
15			* Goal for GitHub.
16			*/
17			class GitHubGoal extends DefaultGoal
18			{
19			public function setName($value)
20			{
21			list($vendor, $package) = explode('/', $value, 2);
22			$this->setItem('name', $value);
23			$this->setItem('vendor', $vendor ?: $package);
24			$this->setItem('package', $package ?: $vendor);
25			}
26
27			public function getName()
28			{
29			return $this->getItem('name') ?: $this->config->package->fullName;
			0 ignored issues – show Documentation introduced 2015-12-14 14:57 UTC by Report Bug Copy Issue Report The property `config` does not exist on `object<hidev\goals\GitHubGoal>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
30			}
31
32			public function getPackage()
33			{
34			return $this->getItem('package') ?: $this->config->package->name;
			0 ignored issues – show Documentation introduced 2015-12-14 14:57 UTC by Report Bug Copy Issue Report The property `config` does not exist on `object<hidev\goals\GitHubGoal>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35			}
36
37			public function getVendor()
38			{
39			return $this->getItem('vendor') ?: $this->config->vendor->name;
			0 ignored issues – show Documentation introduced 2015-12-14 14:57 UTC by Report Bug Copy Issue Report The property `config` does not exist on `object<hidev\goals\GitHubGoal>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40			}
41
42			public function actionCreate()
43			{
44			}
45
46			/**
47			* Clone repo from github.
48			* TODO to work need to redo HiDev to run this action without normal initilization.
49			* @param string $repo full name vendor/package
50			* @return int exit code
51			*/
52			public function actionClone($repo)
53			{
54			return $this->passthru('git', ['clone', '[email protected]:' . $repo]);
			0 ignored issues – show Documentation introduced 2015-12-26 17:18 UTC by Report Bug Copy Issue Report `array('clone', '[email protected]:' . $repo)` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55			}
56			}
57

hiqdev / hidev

Push — master ( 826e4e...164599 )

GitHubGoal::actionClone() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like