Completed
Push — master ( b4a6ad...e2bab1 )
by Andrii
13:50
created

DefaultController   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 7
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 2
c 1
b 0
f 0
lcom 0
cbo 2
dl 0
loc 7
rs 10

1 Method

Rating   Name   Duplication   Size   Complexity  
A actionMake() 0 4 2
1
<?php
2
3
/*
4
 * Task runner, code generator and build tool for easier continuos integration
5
 *
6
 * @link      https://github.com/hiqdev/hidev
7
 * @package   hidev
8
 * @license   BSD-3-Clause
9
 * @copyright Copyright (c) 2014-2016, HiQDev (http://hiqdev.com/)
10
 */
11
12
namespace hidev\controllers;
13
14
/**
15
 * Default goal.
16
 */
17
class DefaultController extends CommonController
18
{
19
    public function actionMake()
20
    {
21
        return StartController::$started ? parent::actionMake() : $this->runRequests(['start', 'default']);
0 ignored issues
show
Documentation introduced by
The property $started is declared private in hidev\controllers\StartController. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

Since your code implements the magic setter _set, this function will be called for any write access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

Since the property has write access only, you can use the @property-write annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
Bug Compatibility introduced by
The expression \hidev\controllers\Start...y('start', 'default')); of type integer|hidev\controllers\Response adds the type hidev\controllers\Response to the return on line 21 which is incompatible with the return type of the parent method hidev\controllers\AbstractController::actionMake of type null|integer.
Loading history...
22
    }
23
}
24