BinaryPhp - Code Metrics - Inspection of "minor" - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5955f6...652d4a )

by Andrii

created 2016-10-17 13:08 UTC

BinaryPhp A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	2
dl	0
loc	55
ccs	0
cts	31
cp	0
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	detectPath()	11	3
A	detectCommand()	6	2
A	install()	13	3
A	getVcsignore()	4	1

<?php

/*
 * Automation tool mixed with code generator for easier continuous development
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hidev\base;

use Yii;

class BinaryPhp extends Binary
{
    /**
     * Detects how to run the binary.
     * Searches in this order:
     * 1. PHAR in project's root directory
     * 2. projects's vendor/bin directory
     * 3. composer global vendor/bin directory.
     *
     * @param string $name
     * @return string path to the binary
     */
    public function detectPath($name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $paths = [Yii::getAlias("@root/$name.phar", false), Yii::getAlias("@root/vendor/bin/$name", false), "$_SERVER[HOME]/.composer/vendor/bin/$name"];
        foreach ($paths as $path) {
            if (file_exists($path)) {
                return $path;

            }
        }

        return parent::detectPath($name);
    }

    /**
     * Detect command execution string.
     * @param mixed $path
     * @return string
     */
    public function detectCommand($path)
    {
        $path = parent::detectCommand($path);

        return is_executable($path) ? $path : '/usr/bin/env php ' . $path;
    }

    public function install()
    {
        if ($this->installer) {
            passthru('/usr/bin/env wget ' . escapeshellarg($this->installer) . ' -O- | /usr/bin/env php', $exitcode);
        } elseif ($this->download) {
            $dest = Yii::getAlias('@root/' . $this->name . '.phar', false);
            passthru('/usr/bin/env wget ' . escapeshellarg($this->download) . ' -O ' . $dest, $exitcode);
        } else {
            return parent::install();
        }

        return $exitcode;
    }

    public function getVcsignore()
    {
        return $this->name . '.phar';
    }
}


1			<?php
2
3			/*
4			* Automation tool mixed with code generator for easier continuous development
5			*
6			* @link https://github.com/hiqdev/hidev
7			* @package hidev
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hidev\base;
13
14			use Yii;
15
16			class BinaryPhp extends Binary
17			{
18			/**
19			* Detects how to run the binary.
20			* Searches in this order:
21			* 1. PHAR in project's root directory
22			* 2. projects's vendor/bin directory
23			* 3. composer global vendor/bin directory.
24			*
25			* @param string $name
26			* @return string path to the binary
27			*/
28			public function detectPath($name)
			0 ignored issues – show Coding Style introduced 2016-01-07 10:00 UTC by Report Bug Copy Issue Report `detectPath` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
29			{
30			$paths = [Yii::getAlias("@root/$name.phar", false), Yii::getAlias("@root/vendor/bin/$name", false), "$_SERVER[HOME]/.composer/vendor/bin/$name"];
31			foreach ($paths as $path) {
32			if (file_exists($path)) {
33			return $path;
			0 ignored issues – show Bug Compatibility introduced 2016-01-07 10:00 UTC by Report Bug Copy Issue Report The expression `return $path;` of type `string\|boolean` is incompatible with the return type of the parent method `hidev\base\Binary::detectPath` of type `string\|null` as it can also be of type `boolean` which is not included in this return type. Loading history...
34			}
35			}
36
37			return parent::detectPath($name);
38			}
39
40			/**
41			* Detect command execution string.
42			* @param mixed $path
43			* @return string
44			*/
45			public function detectCommand($path)
46			{
47			$path = parent::detectCommand($path);
48
49			return is_executable($path) ? $path : '/usr/bin/env php ' . $path;
50			}
51
52			public function install()
53			{
54			if ($this->installer) {
55			passthru('/usr/bin/env wget ' . escapeshellarg($this->installer) . ' -O- \| /usr/bin/env php', $exitcode);
56			} elseif ($this->download) {
57			$dest = Yii::getAlias('@root/' . $this->name . '.phar', false);
58			passthru('/usr/bin/env wget ' . escapeshellarg($this->download) . ' -O ' . $dest, $exitcode);
59			} else {
60			return parent::install();
61			}
62
63			return $exitcode;
64			}
65
66			public function getVcsignore()
67			{
68			return $this->name . '.phar';
69			}
70			}
71

hiqdev / hidev

Push — master ( 5955f6...652d4a )

BinaryPhp A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like