Complex classes like StartController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use StartController, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
23 | class StartController extends CommonController |
||
24 | { |
||
25 | /** |
||
26 | * @var string absolute path to the project root directory |
||
27 | */ |
||
28 | protected $_rootDir; |
||
29 | |||
30 | /** |
||
31 | * @var bool hidev already started flag |
||
32 | */ |
||
33 | public static $started = false; |
||
34 | |||
35 | /** |
||
36 | * Make action. |
||
37 | */ |
||
38 | 2 | public function actionMake() |
|
39 | { |
||
40 | 2 | self::$started = true; |
|
41 | $this->getRootDir(); |
||
42 | $this->includeMainConfig(); |
||
43 | $this->addAliases(); |
||
44 | $this->addAutoloader(); |
||
45 | $this->requireAll(); |
||
46 | $this->includeAll(); |
||
47 | $this->loadConfig(); |
||
48 | $this->includeMainConfig(); |
||
49 | 2 | } |
|
50 | |||
51 | public function includeMainConfig() |
||
52 | { |
||
53 | $this->takeConfig()->includeConfig('.hidev/config.yml'); |
||
54 | if (file_exists('.hidev/config-local.yml')) { |
||
55 | $this->takeConfig()->includeConfig('.hidev/config-local.yml'); |
||
56 | } |
||
57 | } |
||
58 | |||
59 | 2 | public function addAutoloader() |
|
68 | |||
69 | /** |
||
70 | * Update action. |
||
71 | * @return int exit code |
||
72 | */ |
||
73 | public function actionUpdate() |
||
79 | |||
80 | /** |
||
81 | * Adds aliases: |
||
82 | * - @root alias to current project root dir |
||
83 | * - current package namespace for it could be used from hidev. |
||
84 | */ |
||
85 | 2 | public function addAliases() |
|
103 | |||
104 | 2 | public function hasAlias($alias, $exact = true) |
|
110 | |||
111 | /** |
||
112 | * Require all configured requires. |
||
113 | */ |
||
114 | 2 | protected function requireAll() |
|
139 | |||
140 | 2 | public function needsComposerInstall() |
|
162 | |||
163 | /** |
||
164 | * Include all configs. |
||
165 | */ |
||
166 | 2 | public function includeAll() |
|
179 | |||
180 | /** |
||
181 | * Load project's config if configured. |
||
182 | */ |
||
183 | 2 | public function loadConfig() |
|
190 | |||
191 | public function setRootDir($value) |
||
195 | |||
196 | public function getRootDir() |
||
204 | |||
205 | /** |
||
206 | * Chdirs to project's root by looking for config file in the current directory and up. |
||
207 | * @throws InvalidParamException when failed to find |
||
208 | * @return string path to the root directory of hidev project |
||
209 | */ |
||
210 | 2 | protected function findRootDir() |
|
221 | |||
222 | public function buildRootPath($subpath) |
||
226 | } |
||
227 |
If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:
If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.