Completed
Pull Request — master (#2)
by Edgard
06:24
created
src/components/Version.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -103,6 +103,9 @@
 block discarded – undo
103 103
         return $release ?: $this->release ?: 'dev';
104 104
     }
105 105
 
106
+    /**
107
+     * @param string $branch
108
+     */
106 109
     public function setBranch($branch, $release = null)
107 110
     {
108 111
         if (isset($branch) && $release !== 'dev') {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@
 block discarded – undo
89 89
 
90 90
     public function save()
91 91
     {
92
-        $this->getFile()->write($this->renderFile() . "\n");
92
+        $this->getFile()->write($this->renderFile()."\n");
93 93
     }
94 94
 
95 95
     public function setRelease($release = null, $branch = '')
Please login to merge, or discard this patch.
src/base/GettersTrait.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,6 +28,9 @@  discard block
 block discarded – undo
28 28
         return $this->_view;
29 29
     }
30 30
 
31
+    /**
32
+     * @param string $id
33
+     */
31 34
     public function take($id)
32 35
     {
33 36
         return $this->getApp()->get($id);
@@ -43,7 +46,7 @@  discard block
 block discarded – undo
43 46
      * Command output passes unchanged to console.
44 47
      * Returns exit code.
45 48
      * @param string $name
46
-     * @param array|string $args
49
+     * @param string[] $args
47 50
      * @return int exit code
48 51
      */
49 52
     public function passthru($name, $args = [])
Please login to merge, or discard this patch.
src/base/Interpolator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
                 $this->interpolateArray($item);
35 35
             }
36 36
         } elseif (is_string($data)) {
37
-            $data = preg_replace_callback('/\\$(\\w+)\\[\'(.+?)\'\\]/', function ($matches) {
37
+            $data = preg_replace_callback('/\\$(\\w+)\\[\'(.+?)\'\\]/', function($matches) {
38 38
                 return $this->get($matches[1], $matches[2]);
39 39
             }, $data);
40 40
         }
Please login to merge, or discard this patch.
src/config/basis.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
     define('HIDEV_VENDOR_DIR', dirname(dirname(dirname(dirname(__DIR__)))));
13 13
 }
14 14
 
15
-$runtimePath = (substr(__DIR__, 0, 7) === 'phar://' ? dirname($_SERVER['SCRIPT_NAME']) : dirname(HIDEV_VENDOR_DIR)) . '/.hidev/runtime';
15
+$runtimePath = (substr(__DIR__, 0, 7) === 'phar://' ? dirname($_SERVER['SCRIPT_NAME']) : dirname(HIDEV_VENDOR_DIR)).'/.hidev/runtime';
16 16
 
17 17
 return [
18 18
     'id'                    => 'hidev',
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
         ],
88 88
         'own.version' => [
89 89
             'class' => \hidev\components\Version::class,
90
-            'file'  => dirname(dirname(__DIR__)) . '/version',
90
+            'file'  => dirname(dirname(__DIR__)).'/version',
91 91
         ],
92 92
     ],
93 93
     'controllerMap' => [
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     ],
108 108
     'container' => [
109 109
         'singletons' => [
110
-            \hidev\components\AbstractVcs::class => function () {
110
+            \hidev\components\AbstractVcs::class => function() {
111 111
                 $detectedVCS = 'git'; /// TODO actual detection to be added
112 112
                 return Yii::$app->get($detectedVCS);
113 113
             },
Please login to merge, or discard this patch.
src/components/Command.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         foreach ($this->getCommands() as $command) {
46 46
             $command = trim($command);
47 47
             if ($command) {
48
-                passthru(($this->sudo ? 'sudo ' : '') . $command);
48
+                passthru(($this->sudo ? 'sudo ' : '').$command);
49 49
             }
50 50
         }
51 51
         $this->after();
Please login to merge, or discard this patch.
src/console/GithubController.php 2 patches
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     /**
121 121
      * Checks if repo exists.
122 122
      * @param string $repo full name vendor/package defaults to this repo name
123
-     * @return int exit code
123
+     * @return boolean exit code
124 124
      */
125 125
     public function actionExists($repo = null)
126 126
     {
@@ -168,6 +168,10 @@  discard block
 block discarded – undo
168 168
         return 0;
169 169
     }
170 170
 
171
+    /**
172
+     * @param string $method
173
+     * @param string $path
174
+     */
171 175
     public function request($method, $path, $data)
172 176
     {
173 177
         $url = 'https://api.github.com' . $path;
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 
34 34
     public function getFull_name()
35 35
     {
36
-        return $this->getVendor() . '/' . $this->getName();
36
+        return $this->getVendor().'/'.$this->getName();
37 37
     }
38 38
 
39 39
     public function setFullName($value)
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      */
95 95
     public function actionCreate()
96 96
     {
97
-        $res = $this->request('POST', '/orgs/' . $this->getVendor() . '/repos', [
97
+        $res = $this->request('POST', '/orgs/'.$this->getVendor().'/repos', [
98 98
             'name'        => $this->getName(),
99 99
             'description' => $this->getDescription(),
100 100
         ]);
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function actionClone($repo)
116 116
     {
117
-        return $this->passthru('git', ['clone', '[email protected]:' . $repo]);
117
+        return $this->passthru('git', ['clone', '[email protected]:'.$repo]);
118 118
     }
119 119
 
120 120
     /**
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      */
135 135
     public static function exists($repo)
136 136
     {
137
-        return !static::exec('git', ['ls-remote', '[email protected]:' . $repo], true);
137
+        return !static::exec('git', ['ls-remote', '[email protected]:'.$repo], true);
138 138
     }
139 139
 
140 140
     /**
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
             return $wait;
150 150
         }
151 151
 
152
-        return $this->request('POST', '/repos/' . $this->getFull_name() . '/releases', [
152
+        return $this->request('POST', '/repos/'.$this->getFull_name().'/releases', [
153 153
             'tag_name'  => $release,
154 154
             'name'      => $release,
155 155
             'body'      => $notes,
@@ -170,9 +170,9 @@  discard block
 block discarded – undo
170 170
 
171 171
     public function request($method, $path, $data)
172 172
     {
173
-        $url = 'https://api.github.com' . $path;
173
+        $url = 'https://api.github.com'.$path;
174 174
 
175
-        return $this->passthru('curl', ['-X', $method, '-H', 'Authorization: token ' . $this->getToken(), '--data', Json::encode($data), $url]);
175
+        return $this->passthru('curl', ['-X', $method, '-H', 'Authorization: token '.$this->getToken(), '--data', Json::encode($data), $url]);
176 176
     }
177 177
 
178 178
     public function findToken()
Please login to merge, or discard this patch.
src/console/VersionController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
         $version->load();
30 30
         $version->setRelease($release);
31 31
         $dir = dirname($version->getAbspath());
32
-        echo $version->renderFile() . PHP_EOL;
32
+        echo $version->renderFile().PHP_EOL;
33 33
         echo "(run from $dir)\n";
34 34
     }
35 35
 
@@ -44,6 +44,6 @@  discard block
 block discarded – undo
44 44
 
45 45
     public function getComponent()
46 46
     {
47
-        return $this->take(($this->own ? 'own.' : '') . 'version');
47
+        return $this->take(($this->own ? 'own.' : '').'version');
48 48
     }
49 49
 }
Please login to merge, or discard this patch.
src/console/InitController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
             $this->package = $package;
50 50
         }
51 51
         if (!$this->package || !$this->vendor) {
52
-            throw new InvalidParamException('Wrong vendor/package given: ' . $name);
52
+            throw new InvalidParamException('Wrong vendor/package given: '.$name);
53 53
         }
54 54
     }
55 55
 
Please login to merge, or discard this patch.
src/components/Directory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
             $type = isset($config['template']) || isset($config['copy']) ? 'File' : 'Directory';
27 27
             $defaults = [
28 28
                 'class' => "hidev\\components\\$type",
29
-                'path'  => $this->_path . '/' . $id,
29
+                'path'  => $this->_path.'/'.$id,
30 30
             ];
31 31
             $config = array_merge($defaults, $config ?: []);
32 32
             $object = Yii::createObject($config);
Please login to merge, or discard this patch.