BinaryPython - Code Metrics - Inspection of "added BinaryPython" - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1de67f...6c7845 )

by Andrii

created 2016-10-15 18:39 UTC

BinaryPython A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	74
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	8
lcom	1
cbo	2
dl	74
loc	74
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	detectPath()	15	15	3
A	detectCommand()	6	6	2
A	install()	13	13	3

How to fix Duplicated Code

<?php

/*
 * Automation tool mixed with code generator for easier continuous development
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hidev\base;

use Yii;

class BinaryPython extends Binary

{
    /**
     * @var string package full name, e.g. pytest
     */
    public $package;

    /**
     * @var string package version constraint, e.g. ^1.1
     */
    public $version;

    /**
     * @var string installer URL
     */
    public $installer;

    /**
     * @var string URL to download PHAR
     */
    public $download;

    /**
     * Detects how to run the binary.
     * Searches in this order:
     * 1. exexcutable in project's root directory
     * 2. XXX ??? vendor directory
     * 3. /home/user/.local/bin
     *
     * @param string $name
     * @return string path to the binary
     */
    public function detectPath($name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $paths = [
            Yii::getAlias("@root/$name", false),
            Yii::getAlias("@root/env/bin/$name", false),
            "$_SERVER[HOME]/.local/bin/$name",
        ];
        foreach ($paths as $path) {
            if (file_exists($path)) {
                return $path;

            }
        }

        return parent::detectPath($name);
    }

    /**
     * Detect command execution string.
     * @param mixed $path
     * @return string
     */
    public function detectCommand($path)
    {
        $path = parent::detectCommand($path);

        return is_executable($path) ? $path : '/usr/bin/env python ' . $path;
    }

    public function install()
    {
        if ($this->installer) {
            passthru('/usr/bin/env wget ' . escapeshellarg($this->installer) . ' -O- | /usr/bin/env python', $exitcode);
        } elseif ($this->download) {
            $dest = Yii::getAlias('@root/' . $this->name, false);
            passthru('/usr/bin/env wget ' . escapeshellarg($this->download) . ' -O ' . $dest, $exitcode);
        } else {
            passthru("/usr/bin/pip install {$this->package}", $exitcode);
        }

        return $exitcode;
    }
}


1		<?php
2
3		/*
4		* Automation tool mixed with code generator for easier continuous development
5		*
6		* @link https://github.com/hiqdev/hidev
7		* @package hidev
8		* @license BSD-3-Clause
9		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace hidev\base;
13
14		use Yii;
15
16	View Code Duplication	class BinaryPython extends Binary
		0 ignored issues – show Duplication introduced 2016-10-15 18:51 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		/**
19		* @var string package full name, e.g. pytest
20		*/
21		public $package;
22
23		/**
24		* @var string package version constraint, e.g. ^1.1
25		*/
26		public $version;
27
28		/**
29		* @var string installer URL
30		*/
31		public $installer;
32
33		/**
34		* @var string URL to download PHAR
35		*/
36		public $download;
37
38		/**
39		* Detects how to run the binary.
40		* Searches in this order:
41		* 1. exexcutable in project's root directory
42		* 2. XXX ??? vendor directory
43		* 3. /home/user/.local/bin
44		*
45		* @param string $name
46		* @return string path to the binary
47		*/
48		public function detectPath($name)
		0 ignored issues – show Coding Style introduced 2016-10-15 18:51 UTC by Report Bug Copy Issue Report `detectPath` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
49		{
50		$paths = [
51		Yii::getAlias("@root/$name", false),
52		Yii::getAlias("@root/env/bin/$name", false),
53		"$_SERVER[HOME]/.local/bin/$name",
54		];
55		foreach ($paths as $path) {
56		if (file_exists($path)) {
57		return $path;
		0 ignored issues – show Bug Compatibility introduced 2016-10-15 18:51 UTC by Report Bug Copy Issue Report The expression `return $path;` of type `string\|boolean` is incompatible with the return type of the parent method `hidev\base\Binary::detectPath` of type `string\|null` as it can also be of type `boolean` which is not included in this return type. Loading history...
58		}
59		}
60
61		return parent::detectPath($name);
62		}
63
64		/**
65		* Detect command execution string.
66		* @param mixed $path
67		* @return string
68		*/
69		public function detectCommand($path)
70		{
71		$path = parent::detectCommand($path);
72
73		return is_executable($path) ? $path : '/usr/bin/env python ' . $path;
74		}
75
76		public function install()
77		{
78		if ($this->installer) {
79		passthru('/usr/bin/env wget ' . escapeshellarg($this->installer) . ' -O- \| /usr/bin/env python', $exitcode);
80		} elseif ($this->download) {
81		$dest = Yii::getAlias('@root/' . $this->name, false);
82		passthru('/usr/bin/env wget ' . escapeshellarg($this->download) . ' -O ' . $dest, $exitcode);
83		} else {
84		passthru("/usr/bin/pip install {$this->package}", $exitcode);
85		}
86
87		return $exitcode;
88		}
89		}
90

hiqdev / hidev

Push — master ( 1de67f...6c7845 )

BinaryPython A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like