StartController::actionMake() - Code Metrics - Inspection of "bump" - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6c7845...2aa843 )

by Andrii

created 2016-10-15 18:54 UTC

StartController::actionMake() A

↳ Parent: StartController

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	3.5388

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
dl	0
loc	14
ccs	3
cts	11
cp	0.2727
rs	9.4285
c	4
b	1
f	1
cc	2
eloc	11
nc	2
nop	0
crap	3.5388

<?php

/*
 * Automation tool mixed with code generator for easier continuous development
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hidev\controllers;

use hidev\base\File;
use Yii;
use yii\base\InvalidParamException;
use yii\helpers\ArrayHelper;

/**
 * Start goal.
 * Chdirs to the project's root directory and loads dependencies and configs.
 */
class StartController extends CommonController
{
    /**
     * @var string absolute path to the project root directory
     */
    protected $_rootDir;

    /**
     * @var bool hidev already started flag
     */
    public static $started = false;

    /**
     * Make action.
     */
    public function actionMake()
    {
        $this->getRootDir();
        $this->takeConfig()->includeConfig('.hidev/config.yml');
        if (file_exists('.hidev/config-local.yml')) {
            $this->takeConfig()->includeConfig('.hidev/config-local.yml');
        }
        $this->addAliases();
        $this->addAutoloader();
        $this->requireAll();
        $this->includeAll();
        $this->loadConfig();
        self::$started = true;
    }

    public function addAutoloader()
    {
        $autoloader = Yii::getAlias('@root/vendor/autoload.php');
        if (file_exists($autoloader)) {
            spl_autoload_unregister(['Yii', 'autoload']);
            require $autoloader;
            spl_autoload_register(['Yii', 'autoload'], true, true);
        }
    }

    /**
     * Update action.
     * @return int exit code
     */
    public function actionUpdate()
    {
        return $this->passthru('composer', ['update', '-d', '.hidev', '--prefer-source', '--ansi']);
    }

    /**
     * Adds aliases:
     * - @root alias to current project root dir
     * - current package namespace for it could be used from hidev.
     */
    public function addAliases()
    {
        Yii::setAlias('@root', $this->getRootDir());
        $config = $this->takeConfig()->rawItem('package');
        $alias  = strtr($config['namespace'], '\\', '/');
        if ($alias && !Yii::getAlias('@' . $alias, false)) {
            $srcdir = Yii::getAlias('@root/' . ($config['src'] ?: 'src'));
            Yii::setAlias($alias, $srcdir);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }
        $aliases = $this->takeConfig()->rawItem('aliases');
        if (!empty($aliases) && is_array($aliases)) {
            foreach ($aliases as $alias => $path) {
                if (!$this->hasAlias($alias)) {
                    Yii::setAlias($alias, $path);
                }
            }
        }
    }

    public function hasAlias($alias, $exact = true)

    {
        $pos = strpos($alias, '/');

        return $pos === false ? isset(Yii::$aliases[$alias]) : isset(Yii::$aliases[substr($alias, 0, $pos)][$alias]);
    }

    /**
     * Require all configured requires.
     */
    protected function requireAll()
    {
        $plugins = $this->takeConfig()->rawItem('plugins');
        $vendors = [];
        if ($plugins) {
            $file = File::create('.hidev/composer.json');
            $data = ArrayHelper::merge($file->load(), ['require' => $plugins]);
            if ($file->save($data) || !is_dir('.hidev/vendor')) {
                $this->runAction('update');
            }
            $vendors[] = '.hidev/vendor';
        } elseif ($this->needsComposerInstall()) {
            if ($this->passthru('composer', ['install', '--ansi'])) {
                throw new InvalidParamException('Failed initialize project with composer install');
            }
        }
        if (file_exists('vendor/hiqdev/config/hidev.php')) {
            $vendors[] = 'vendor';
        }
        if (!empty($vendors)) {
            foreach (array_unique($vendors) as $dir) {
                $this->module->loadExtraVendor($dir);
            }
        }
    }

    public function needsComposerInstall()
    {
        if (file_exists('vendor')) {
            return false;
        }
        if (!file_exists('composer.json')) {
            return false;
        }
        $data = File::create('composer.json')->load();
        foreach (['require', 'require-dev'] as $key) {
            if (isset($data[$key])) {
                foreach ($data[$key] as $package => $version) {
                    list(, $name) = explode('/', $package);
                    if (strncmp($name, 'hidev-', 6) === 0) {
                        return true;
                    }
                }
            }
        }

        return false;
    }

    /**
     * Include all configs.
     */
    public function includeAll()
    {
        $still = true;
        while ($still) {
            $still = false;
            $include = $this->takeConfig()->rawItem('include');
            if ($include) {
                foreach ($include as $path) {
                    $still = $still || $this->takeConfig()->includeConfig($path);
                }
            }
        }
    }

    /**
     * Load project's config if configured.
     */
    public function loadConfig()
    {
        $path = $this->takeConfig()->rawItem('config');
        if ($path) {
            $this->module->loadExtraConfig($path);
        }
    }

    public function setRootDir($value)
    {
        $this->_rootDir = $value;
    }

    public function getRootDir()
    {
        if ($this->_rootDir === null) {
            $this->_rootDir = $this->findRootDir();
        }

        return $this->_rootDir;
    }

    /**
     * Chdirs to project's root by looking for config file in the current directory and up.
     * @throws InvalidParamException when failed to find
     * @return string path to the root directory of hidev project
     */
    protected function findRootDir()
    {
        $configDir = '.hidev';
        for ($i = 0;$i < 9;++$i) {
            if (is_dir($configDir)) {
                return getcwd();
            }
            chdir('..');
        }
        throw new InvalidParamException("Not a hidev project (or any of the parent directories).\nUse `hidev init` to initialize hidev project.");
    }

    public function buildRootPath($subpath)
    {
        return $this->getRootDir() . DIRECTORY_SEPARATOR . $subpath;
    }
}


1		<?php
2
3		/*
4		* Automation tool mixed with code generator for easier continuous development
5		*
6		* @link https://github.com/hiqdev/hidev
7		* @package hidev
8		* @license BSD-3-Clause
9		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace hidev\controllers;
13
14		use hidev\base\File;
15		use Yii;
16		use yii\base\InvalidParamException;
17		use yii\helpers\ArrayHelper;
18
19		/**
20		* Start goal.
21		* Chdirs to the project's root directory and loads dependencies and configs.
22		*/
23		class StartController extends CommonController
24		{
25		/**
26		* @var string absolute path to the project root directory
27		*/
28		protected $_rootDir;
29
30		/**
31		* @var bool hidev already started flag
32		*/
33		public static $started = false;
34
35		/**
36		* Make action.
37		*/
38	2	public function actionMake()
39		{
40		$this->getRootDir();
41		$this->takeConfig()->includeConfig('.hidev/config.yml');
42		if (file_exists('.hidev/config-local.yml')) {
43		$this->takeConfig()->includeConfig('.hidev/config-local.yml');
44		}
45		$this->addAliases();
46		$this->addAutoloader();
47		$this->requireAll();
48		$this->includeAll();
49		$this->loadConfig();
50	2	self::$started = true;
51	2	}
52
53	2	public function addAutoloader()
54		{
55		$autoloader = Yii::getAlias('@root/vendor/autoload.php');
56		if (file_exists($autoloader)) {
57		spl_autoload_unregister(['Yii', 'autoload']);
58		require $autoloader;
59		spl_autoload_register(['Yii', 'autoload'], true, true);
60		}
61	2	}
62
63		/**
64		* Update action.
65		* @return int exit code
66		*/
67		public function actionUpdate()
68		{
69		return $this->passthru('composer', ['update', '-d', '.hidev', '--prefer-source', '--ansi']);
70		}
71
72		/**
73		* Adds aliases:
74		* - @root alias to current project root dir
75		* - current package namespace for it could be used from hidev.
76		*/
77	2	public function addAliases()
78		{
79		Yii::setAlias('@root', $this->getRootDir());
80		$config = $this->takeConfig()->rawItem('package');
81		$alias = strtr($config['namespace'], '\\', '/');
82	2	if ($alias && !Yii::getAlias('@' . $alias, false)) {
83		$srcdir = Yii::getAlias('@root/' . ($config['src'] ?: 'src'));
84		Yii::setAlias($alias, $srcdir);
		0 ignored issues – show Bug introduced 2016-05-06 07:50 UTC by Report Bug Copy Issue Report It seems like `$srcdir` defined by `\Yii::getAlias('@root/' ...onfig['src'] ?: 'src'))` on line `83` can also be of type `boolean`; however, `yii\BaseYii::setAlias()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
85		}
86		$aliases = $this->takeConfig()->rawItem('aliases');
87		if (!empty($aliases) && is_array($aliases)) {
88		foreach ($aliases as $alias => $path) {
89		if (!$this->hasAlias($alias)) {
90		Yii::setAlias($alias, $path);
91		}
92		}
93		}
94	2	}
95
96	2	public function hasAlias($alias, $exact = true)
		0 ignored issues – show Unused Code introduced 2016-05-16 15:35 UTC by Report Bug Copy Issue Report The parameter `$exact` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
97		{
98		$pos = strpos($alias, '/');
99
100		return $pos === false ? isset(Yii::$aliases[$alias]) : isset(Yii::$aliases[substr($alias, 0, $pos)][$alias]);
101	2	}
102
103		/**
104		* Require all configured requires.
105		*/
106	2	protected function requireAll()
107		{
108		$plugins = $this->takeConfig()->rawItem('plugins');
109	2	$vendors = [];
110	2	if ($plugins) {
111		$file = File::create('.hidev/composer.json');
112		$data = ArrayHelper::merge($file->load(), ['require' => $plugins]);
113		if ($file->save($data) \|\| !is_dir('.hidev/vendor')) {
114		$this->runAction('update');
115		}
116		$vendors[] = '.hidev/vendor';
117		} elseif ($this->needsComposerInstall()) {
118		if ($this->passthru('composer', ['install', '--ansi'])) {
119		throw new InvalidParamException('Failed initialize project with composer install');
120		}
121		}
122		if (file_exists('vendor/hiqdev/config/hidev.php')) {
123		$vendors[] = 'vendor';
124		}
125	2	if (!empty($vendors)) {
126		foreach (array_unique($vendors) as $dir) {
127		$this->module->loadExtraVendor($dir);
128		}
129		}
130	2	}
131
132	2	public function needsComposerInstall()
133		{
134		if (file_exists('vendor')) {
135		return false;
136		}
137		if (!file_exists('composer.json')) {
138	2	return false;
139		}
140		$data = File::create('composer.json')->load();
141		foreach (['require', 'require-dev'] as $key) {
142		if (isset($data[$key])) {
143		foreach ($data[$key] as $package => $version) {
144		list(, $name) = explode('/', $package);
145		if (strncmp($name, 'hidev-', 6) === 0) {
146		return true;
147		}
148		}
149		}
150		}
151
152		return false;
153		}
154
155		/**
156		* Include all configs.
157		*/
158	2	public function includeAll()
159		{
160	2	$still = true;
161		while ($still) {
162	2	$still = false;
163		$include = $this->takeConfig()->rawItem('include');
164	2	if ($include) {
165		foreach ($include as $path) {
166		$still = $still \|\| $this->takeConfig()->includeConfig($path);
167		}
168		}
169		}
170	2	}
171
172		/**
173		* Load project's config if configured.
174		*/
175	2	public function loadConfig()
176		{
177		$path = $this->takeConfig()->rawItem('config');
178	2	if ($path) {
179		$this->module->loadExtraConfig($path);
180		}
181	2	}
182
183		public function setRootDir($value)
184		{
185		$this->_rootDir = $value;
186		}
187
188		public function getRootDir()
189		{
190		if ($this->_rootDir === null) {
191		$this->_rootDir = $this->findRootDir();
192		}
193
194		return $this->_rootDir;
195		}
196
197		/**
198		* Chdirs to project's root by looking for config file in the current directory and up.
199		* @throws InvalidParamException when failed to find
200		* @return string path to the root directory of hidev project
201		*/
202	2	protected function findRootDir()
203		{
204	2	$configDir = '.hidev';
205		for ($i = 0;$i < 9;++$i) {
206		if (is_dir($configDir)) {
207		return getcwd();
208		}
209		chdir('..');
210	2	}
211		throw new InvalidParamException("Not a hidev project (or any of the parent directories).\nUse `hidev init` to initialize hidev project.");
212		}
213
214		public function buildRootPath($subpath)
215		{
216		return $this->getRootDir() . DIRECTORY_SEPARATOR . $subpath;
217		}
218		}
219

hiqdev / hidev

Push — master ( 6c7845...2aa843 )

StartController::actionMake() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like