DirectoryController::actionSave() - Code Metrics - Inspection of "minor" - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61af37...142460 )

by Andrii

created 2016-02-23 17:18 UTC

DirectoryController::actionSave() B

↳ Parent: DirectoryController

Complexity

Conditions	5
Paths	6

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
ccs	0
cts	14
cp	0
rs	8.8571
cc	5
eloc	9
nc	6
nop	0
crap	30

<?php

/*
 * Task runner, code generator and build tool for easier continuos integration
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hidev\controllers;

use Yii;

/**
 * Directory controller.
 */
class DirectoryController extends FileController
{
    /**
     * Load action.
     * @return void
     */
    public function actionLoad()
    {
        /// nothing for the moment
    }

    public function hasPath()
    {
        return $this->_file || $this->_path;
    }

    public function actionSave()
    {
        if (!file_exists($this->path)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->mkdir($this->path);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        foreach ($this->getItems() as $id => $config) {
            $defaults = [
                'class' => isset($config['template']) ? 'template' : 'directory',
                'file'  => $this->path . '/' . $id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ];
            $goal = $this->takeConfig()->createItem($id, array_merge($defaults, $config ?: []));
            $goal->perform();
        }
    }

    public function mkdir($path)
    {
        Yii::warning('mkdir ' . $path, 'dir');
        mkdir($path);
    }
}


1			<?php
2
3			/*
4			* Task runner, code generator and build tool for easier continuos integration
5			*
6			* @link https://github.com/hiqdev/hidev
7			* @package hidev
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hidev\controllers;
13
14			use Yii;
15
16			/**
17			* Directory controller.
18			*/
19			class DirectoryController extends FileController
20			{
21			/**
22			* Load action.
23			* @return void
24			*/
25			public function actionLoad()
26			{
27			/// nothing for the moment
28			}
29
30			public function hasPath()
31			{
32			return $this->_file \|\| $this->_path;
33			}
34
35			public function actionSave()
36			{
37			if (!file_exists($this->path)) {
			0 ignored issues – show Documentation introduced 2016-02-13 16:07 UTC by Report Bug Copy Issue Report The property `path` does not exist on `object<hidev\controllers\DirectoryController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			$this->mkdir($this->path);
			0 ignored issues – show Documentation introduced 2016-02-13 16:07 UTC by Report Bug Copy Issue Report The property `path` does not exist on `object<hidev\controllers\DirectoryController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
39			}
40			foreach ($this->getItems() as $id => $config) {
41			$defaults = [
42			'class' => isset($config['template']) ? 'template' : 'directory',
43			'file' => $this->path . '/' . $id,
			0 ignored issues – show Documentation introduced 2016-02-13 16:07 UTC by Report Bug Copy Issue Report The property `path` does not exist on `object<hidev\controllers\DirectoryController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44			];
45			$goal = $this->takeConfig()->createItem($id, array_merge($defaults, $config ?: []));
46			$goal->perform();
47			}
48			}
49
50			public function mkdir($path)
51			{
52			Yii::warning('mkdir ' . $path, 'dir');
53			mkdir($path);
54			}
55			}
56

hiqdev / hidev

Push — master ( 61af37...142460 )

DirectoryController::actionSave() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like