Interpolator::interpolate() - Code Metrics - Inspection of "csfixed" - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 375de1...c13e1e )

by Andrii

created 2017-04-29 16:59 UTC

Interpolator::interpolate() A

↳ Parent: Interpolator

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	12
rs	9.2
cc	4
eloc	8
nc	4
nop	1

<?php
/**
 * Automation tool mixed with code generator for easier continuous development
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hidev\base;

use Yii;
use yii\helpers\ArrayHelper;

class Interpolator
{
    public function interpolate(&$data)
    {
        if (is_array($data)) {
            foreach ($data as &$item) {
                $this->interpolate($item);
            }
        } elseif (is_string($data)) {
            $data = preg_replace_callback('/\\$(\\w+)\\[\'(.+?)\'\\]/', function ($matches) {
                return $this->get($matches[1], $matches[2]);
            }, $data);
        }
    }

    public function get($scope, $name)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($scope === 'params') {
            return Yii::$app->params[$name];
        } elseif ($scope === '_ENV') {
            return $_ENV[$name];
        } elseif ($scope === 'config') {
            return $this->getConfig($name);
        } else {
            return "\$${scope}['$name']";
        }
    }

    public function getConfig($name)
    {
        list($goal, $subname) = explode('.', $name, 2);

        return ArrayHelper::getValue(Yii::$app->get('config')->getGoal($goal), $subname);
    }
}


1			<?php
2			/**
3			* Automation tool mixed with code generator for easier continuous development
4			*
5			* @link https://github.com/hiqdev/hidev
6			* @package hidev
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hidev\base;
12
13			use Yii;
14			use yii\helpers\ArrayHelper;
15
16			class Interpolator
17			{
18			public function interpolate(&$data)
19			{
20			if (is_array($data)) {
21			foreach ($data as &$item) {
22			$this->interpolate($item);
23			}
24			} elseif (is_string($data)) {
25			$data = preg_replace_callback('/\\$(\\w+)\\[\'(.+?)\'\\]/', function ($matches) {
26			return $this->get($matches[1], $matches[2]);
27			}, $data);
28			}
29			}
30
31			public function get($scope, $name)
			0 ignored issues – show Coding Style introduced 2017-04-18 16:28 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_ENV` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
32			{
33			if ($scope === 'params') {
34			return Yii::$app->params[$name];
35			} elseif ($scope === '_ENV') {
36			return $_ENV[$name];
37			} elseif ($scope === 'config') {
38			return $this->getConfig($name);
39			} else {
40			return "\$${scope}['$name']";
41			}
42			}
43
44			public function getConfig($name)
45			{
46			list($goal, $subname) = explode('.', $name, 2);
47
48			return ArrayHelper::getValue(Yii::$app->get('config')->getGoal($goal), $subname);
49			}
50			}
51

hiqdev / hidev

Push — master ( 375de1...c13e1e )

Interpolator::interpolate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like