hidev\controllers\CommonBehavior

Complexity

Total Complexity

17

Size/Duplication

Total Lines	72
Duplicated Lines	34.72 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	events()	0	7	1
A	onBeforeAction()	0	4	1
A	onAfterAction()	0	4	1
A	runRequests()	11	11	4
B	normalizeTasks()	14	14	6
A	isNotOk()	0	4	2
A	runRequest()	0	9	2

<?php
/**
 * Automation tool mixed with code generator for easier continuous development
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hidev\controllers;

use Yii;
use yii\console\Request;

/**
 * Common controller behavior.
 */
class CommonBehavior extends \yii\base\Behavior
{
    public function events()
    {
        return [
            CommonController::EVENT_BEFORE_ACTION => 'onBeforeAction',
            CommonController::EVENT_AFTER_ACTION  => 'onAfterAction',
        ];
    }

    public function onBeforeAction($event)
    {
        $this->runRequests($event->sender->before);
    }

    public function onAfterAction($event)
    {
        $this->runRequests($event->sender->after);
    }

    public function runRequests($requests)

This method seems to be duplicated in your project.

    {
        foreach ($this->normalizeTasks($requests) as $request => $enabled) {
            if ($enabled) {
                $response = $this->runRequest($request);
                if ($this->isNotOk($response)) {
                    return $response;
                }
            }
        }
    }

    public function normalizeTasks($tasks)

This method seems to be duplicated in your project.

    {
        if (!$tasks) {
            return [];
        } elseif (!is_array($tasks)) {
            $tasks = [(string) $tasks => 1];
        }
        $res = [];
        foreach ($tasks as $dep => $enabled) {
            $res[(string) (is_int($dep) ? $enabled : $dep)] = (bool) (is_int($dep) ? 1 : $enabled);
        }

        return $res;
    }

    /**
     * Is response NOT Ok.
     * @param Response|int $response
     * @return bool
     */
    public function isNotOk($response)
    {
        return is_object($response) ? $response->exitStatus : $response;
    }

    /**
     * Run request.
     * @param string|array $query
     * @return Response
     */
    public function runRequest($query)
    {
        $request = Yii::createObject([
            'class'  => Request::class,
            'params' => is_array($query) ? $query : array_filter(explode(' ', $query)),
        ]);

        return Yii::$app->handleRequest($request);
    }
}