VersionController::actionMake() - Code Metrics - Inspection of "version bump to 0.3.6" - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 27ccb2...cf0928 )

by Andrii

created 2016-01-17 10:15 UTC

VersionController::actionMake() B

↳ Parent: VersionController

Complexity

Conditions	5
Paths	16

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	9
ccs	0
cts	9
cp	0
rs	8.8571
cc	5
eloc	6
nc	16
nop	1
crap	30

<?php

/*
 * Task runner, code generator and build tool for easier continuos integration
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2014-2016, HiQDev (http://hiqdev.com/)
 */

namespace hidev\controllers;

/**
 * Goal for version file management.
 */
class VersionController extends FileController
{
    protected $_file = 'version';

    public $version;
    public $date;
    public $time;
    public $zone;
    public $hash;

    public function init()
    {
        $v = trim($this->getFile()->read());
        list($this->version, $this->date, $this->time, $this->zone, $this->hash) = explode(' ', $v);
    }

    public function actionMake($version = null)
    {
        list($date, $time, $zone, $hash) = explode(' ', trim(reset($this->exec('git', ['log', '-n', 1, '--pretty=%ai %H']))));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if ($hash !== $this->hash) {
            $this->version = 'dev';
        }
        $version = $version ?: $this->takeGoal('bump')->version ?: $this->version ?: 'dev';
        $this->getFile()->write(implode(' ', [$version, $date, $time, $zone, $hash]) . "\n");
    }
}


1			<?php
2
3			/*
4			* Task runner, code generator and build tool for easier continuos integration
5			*
6			* @link https://github.com/hiqdev/hidev
7			* @package hidev
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2014-2016, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hidev\controllers;
13
14			/**
15			* Goal for version file management.
16			*/
17			class VersionController extends FileController
18			{
19			protected $_file = 'version';
20
21			public $version;
22			public $date;
23			public $time;
24			public $zone;
25			public $hash;
26
27			public function init()
28			{
29			$v = trim($this->getFile()->read());
30			list($this->version, $this->date, $this->time, $this->zone, $this->hash) = explode(' ', $v);
31			}
32
33			public function actionMake($version = null)
34			{
35			list($date, $time, $zone, $hash) = explode(' ', trim(reset($this->exec('git', ['log', '-n', 1, '--pretty=%ai %H']))));
			0 ignored issues – show Bug introduced 2016-01-16 15:41 UTC by Report Bug Copy Issue Report `$this->exec('git', array... 1, '--pretty=%ai %H'))` cannot be passed to `reset()` as the parameter `$array` expects a reference. Loading history... Documentation introduced 2016-01-16 15:41 UTC by Report Bug Copy Issue Report `array('log', '-n', 1, '--pretty=%ai %H')` is of type `array<integer,string\|int...integer","3":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			if ($hash !== $this->hash) {
37			$this->version = 'dev';
38			}
39			$version = $version ?: $this->takeGoal('bump')->version ?: $this->version ?: 'dev';
40			$this->getFile()->write(implode(' ', [$version, $date, $time, $zone, $hash]) . "\n");
41			}
42			}
43

hiqdev / hidev

Push — master ( 27ccb2...cf0928 )

VersionController::actionMake() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like