Request::getParams() - Code Metrics - Inspection of "minor" - hiqdev/hidev - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a6b26f...19dee2 )

by Andrii

created 2016-10-17 08:56 UTC

Request::getParams() A

↳ Parent: Request

Complexity

Conditions	4
Paths	4

Size

Total Lines	21
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	12.9353

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	21
ccs	3
cts	17
cp	0.1765
rs	9.0534
cc	4
eloc	15
nc	4
nop	0
crap	12.9353

<?php

/*
 * Automation tool mixed with code generator for easier continuous development
 *
 * @link      https://github.com/hiqdev/hidev
 * @package   hidev
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hidev\base;

use Yii;

/**
 * The Request.
 * Redefined for aliases.
 */
class Request extends \yii\console\Request
{
    /**
     * @var name of script called, like $0 in sh/perl
     */
    protected $_self;

    protected $_args;

    /**
     * Returns the command line arguments.
     *
     * @return array the command line arguments. It does not include the entry script name
     */
    public function getParams()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($this->_args)) {
            if (isset($_SERVER['argv'])) {
                $args        = $_SERVER['argv'];
                $this->_self = array_shift($args);
                $command     = $args[0];
                $alias       = Yii::$app->config->aliases->get($command);
                if ($alias) {
                    array_shift($args);
                    $args = array_merge($alias, $args);
                }
                $this->_args = $args;
            } else {
                $this->_args = [];
            }
            $this->setParams($this->_args);
        }

        return $this->_args;
    }

    public function setParams($params)
    {
        parent::setParams($params);
        $this->_args = $params;
    }
}


1		<?php
2
3		/*
4		* Automation tool mixed with code generator for easier continuous development
5		*
6		* @link https://github.com/hiqdev/hidev
7		* @package hidev
8		* @license BSD-3-Clause
9		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace hidev\base;
13
14		use Yii;
15
16		/**
17		* The Request.
18		* Redefined for aliases.
19		*/
20		class Request extends \yii\console\Request
21		{
22		/**
23		* @var name of script called, like $0 in sh/perl
24		*/
25		protected $_self;
26
27		protected $_args;
28
29		/**
30		* Returns the command line arguments.
31		*
32		* @return array the command line arguments. It does not include the entry script name
33		*/
34	5	public function getParams()
		0 ignored issues – show Coding Style introduced 2015-12-02 18:05 UTC by Report Bug Copy Issue Report `getParams` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
35		{
36	5	if (!isset($this->_args)) {
37		if (isset($_SERVER['argv'])) {
38		$args = $_SERVER['argv'];
39		$this->_self = array_shift($args);
40		$command = $args[0];
41		$alias = Yii::$app->config->aliases->get($command);
42		if ($alias) {
43		array_shift($args);
44		$args = array_merge($alias, $args);
45		}
46		$this->_args = $args;
47		} else {
48		$this->_args = [];
49		}
50		$this->setParams($this->_args);
51		}
52
53	5	return $this->_args;
54		}
55
56	5	public function setParams($params)
57		{
58	5	parent::setParams($params);
59	5	$this->_args = $params;
60	5	}
61		}
62

hiqdev / hidev

Push — master ( a6b26f...19dee2 )

Request::getParams() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like