Issues in ScrutinizerGoal.php - New Issues - Inspection of "version bump 0.2.0" - hiqdev/hidev-scrutinizer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8293e4...9f993a )

by Andrii

created 2015-12-23 16:14 UTC

src/goals/ScrutinizerGoal.php (1 issue)

Showing only issues like (Show All)

mismatching argument types.

Documentation Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * Scrutinizer plugin for HiDev
 *
 * @link      https://github.com/hiqdev/hidev-scrutinizer
 * @package   hidev-scrutinizer
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015, HiQDev (http://hiqdev.com/)
 */

namespace hidev\scrutinizer\goals;

/**
 * Goal for Scrutinizer.
 */
class ScrutinizerGoal extends \hidev\goals\DefaultGoal
{
    public function actionUploadCoverage()
    {
        return $this->runActions(['wget-ocular', 'run-ocular']);
    }

    public function actionWgetOcular()
    {
        if (file_exists('ocular.phar')) {
            return 0;
        }

        return $this->passthru('wget', 'https://scrutinizer-ci.com/ocular.phar');
    }

    public function actionRunOcular()
    {
        return $this->passthru('ocular', ['code-coverage:upload', '--format=php-clover', 'coverage.clover']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			/*
4			* Scrutinizer plugin for HiDev
5			*
6			* @link https://github.com/hiqdev/hidev-scrutinizer
7			* @package hidev-scrutinizer
8			* @license BSD-3-Clause
9			* @copyright Copyright (c) 2015, HiQDev (http://hiqdev.com/)
10			*/
11
12			namespace hidev\scrutinizer\goals;
13
14			/**
15			* Goal for Scrutinizer.
16			*/
17			class ScrutinizerGoal extends \hidev\goals\DefaultGoal
18			{
19			public function actionUploadCoverage()
20			{
21			return $this->runActions(['wget-ocular', 'run-ocular']);
22			}
23
24			public function actionWgetOcular()
25			{
26			if (file_exists('ocular.phar')) {
27			return 0;
28			}
29
30			return $this->passthru('wget', 'https://scrutinizer-ci.com/ocular.phar');
31			}
32
33			public function actionRunOcular()
34			{
35			return $this->passthru('ocular', ['code-coverage:upload', '--format=php-clover', 'coverage.clover']);
			0 ignored issues – show Documentation introduced 2015-12-23 16:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('code-coverage:upl...er', 'coverage.clover')` is of type `array<integer,string,{"0..."string","2":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			}
37			}
38

hiqdev / hidev-scrutinizer

Push — master ( 8293e4...9f993a )

src/goals/ScrutinizerGoal.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like