hidev\phpunit\controllers\PhpunitController

Complexity

Total Complexity

30

Size/Duplication

Total Lines	145
Duplicated Lines	13.79 %

Coupling/Cohesion

Components	2
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

17 Methods

Rating	Name	Duplication	Size	Complexity
A	getConfiguration()	0	4	1
A	getBootstrapFile()	0	12	2
A	actionBootstrap()	0	6	2
A	actionMake()	0	4	1
B	actionRun()	0	15	6
A	getVersion()	0	10	2
A	actionGenfake()	10	10	3
A	genFake()	0	9	1
A	actionGentest()	10	10	3
A	genSkel()	0	7	1
A	buildNamespace()	0	4	2
A	buildTestNamespace()	0	4	1
A	buildClass()	0	4	1
A	buildTestClass()	0	4	1
A	buildPath()	0	4	1
A	buildTestPath()	0	4	1
A	buildFakePath()	0	4	1

<?php

/*
 * PHPUnit plugin for HiDev
 *
 * @link      https://github.com/hiqdev/hidev-phpunit
 * @package   hidev-phpunit
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hidev\phpunit\controllers;

use hidev\base\File;
use hidev\handlers\BaseHandler;
use Yii;

/**
 * Goal for Phpunit.
 */
class PhpunitController extends \hidev\controllers\CommonController
{
    protected $_before = ['phpunit/bootstrap', 'phpunit.xml.dist'];

    protected $_version;

    protected $_bootstrapFile;

    public $force;
    public $colors;
    public $coverageText;
    public $coverageClover;

    public function getConfiguration()
    {
        return $this->getGoal('phpunit.xml.dist');

The method getGoal does not exist on object<hidev\phpunit\controllers\PhpunitController>? Since you implemented __call, maybe consider adding a @method annotation.

    }

    public function getBootstrapFile()
    {
        if ($this->_bootstrapFile === null) {
            $this->_bootstrapFile = Yii::createObject([
                'class'     => File::class,
                'template'  => 'phpunit/bootstrap.twig',
                'path'      => 'tests/_bootstrap.php',
            ]);
        }

        return $this->_bootstrapFile;
    }

    public function actionBootstrap()
    {
        if (!$this->getBootstrapFile()->exists()) {
            $this->getBootstrapFile()->save();
        }
    }

    public function actionMake()
    {
        return $this->actionRun();
    }

    public function actionRun()
    {
        $args = [];
        if ($this->coverageText) {
            $args[] = '--coverage-text';
        }
        if ($this->coverageClover) {
            $args[] = '--coverage-clover=' . (is_string($this->coverageClover) ? $this->coverageClover : 'coverage.clover');
        }
        if ($this->colors) {
            $args[] = '--colors' . (version_compare($this->getVersion(), '4.7.0', '>=') ? '=' . $this->colors : '');
        }

        return $this->passthru('phpunit', $args);

$args is of type array, but the function expects a string.

    }

    public function getVersion()
    {
        if ($this->_version === null) {
            $lines = $this->exec('phpunit', ['--version']);

array('--version') is of type array<integer,string,{"0":"string"}>, but the function expects a string.

            $a = explode(' ', $lines[0], 3)[1];
            $this->_version = $a;
        }

        return $this->_version;
    }

    public function actionGenfake($file)

This method seems to be duplicated in your project.

    {
        $path = $this->buildFakePath($file);
        if (!$this->force && file_exists($path)) {
            Yii::warning("already exists: $path");
            return 1;
        }

        return $this->genFake($file, $path);
    }

    public function genFake($file, $path)
    {
        $text = $this->getView()->render('phpunit/fake.twig', [
            'class'         => $this->buildClass($file),
            'namespace'     => $this->buildTestNamespace(),
            'name'          => $file,
        ]);
        BaseHandler::write($path, $text);
    }

    public function actionGentest($file)

This method seems to be duplicated in your project.

    {
        $path = $this->buildTestPath($file);
        if (!$this->force && file_exists($path)) {
            Yii::warning("already exists: $path");
            return 1;
        }

        return $this->genSkel($file);
    }

    public function genSkel($file)
    {
        return $this->passthru('phpunit-skelgen', [

array('generate-test', '--bootstrap', 'tests/_bootstrap.php', '--', $this->buildClass($file), $this->buildPath($file), $this->buildTestClass($file), $this->buildTestPath($file)) is of type array<integer,string,{"0":"string","1":"string","2":"string","3":"string","4":"string","5":"string","6":"string","7":"string"}>, but the function expects a string.

            'generate-test', '--bootstrap', 'tests/_bootstrap.php', '--',
            $this->buildClass($file), $this->buildPath($file), $this->buildTestClass($file), $this->buildTestPath($file),
        ]);
    }

    public function buildNamespace($dir = '')
    {
        return $this->package->namespace . ($dir ? '\\' . strtr($dir, '/', '\\') : '');

The property package does not exist on object<hidev\phpunit\controllers\PhpunitController>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    public function buildTestNamespace($dir = 'tests\\unit')
    {
        return $this->buildNamespace($dir);
    }

    public function buildClass($file, $dir = '')
    {
        return $this->buildNamespace($dir) . '\\' . strtr($file, '/', '\\');
    }

    public function buildTestClass($file, $dir = 'tests\\unit')
    {
        return $this->buildClass($file, $dir);
    }

    public function buildPath($file, $dir = 'src', $prefix = '', $postfix = '')
    {
        return $dir . DIRECTORY_SEPARATOR . $prefix . $file . $postfix . '.php';
    }

    public function buildTestPath($file, $dir = 'tests/unit', $prefix = '', $postfix = 'Test')
    {
        return $this->buildPath($file, $dir, $prefix, $postfix);
    }

    public function buildFakePath($file, $dir = 'tests/unit', $prefix = 'Fake', $postfix = '')
    {
        return $this->buildPath($file, $dir, $prefix, $postfix);
    }
}