Issues in PhpunitController.php - New Issues - Inspection of "version bump to 0.3.4" - hiqdev/hidev-phpunit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1c2bc2...978448 )

by Andrii

created 2016-04-13 18:17 UTC

src/controllers/PhpunitController.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * PHPUnit plugin for HiDev
 *
 * @link      https://github.com/hiqdev/hidev-phpunit
 * @package   hidev-phpunit
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
 */

namespace hidev\phpunit\controllers;

use hidev\base\File;
use hidev\handlers\BaseHandler;
use Yii;

/**
 * Goal for Phpunit.
 */
class PhpunitController extends \hidev\controllers\CommonController
{
    protected $_before = ['phpunit/bootstrap', 'phpunit.xml.dist'];

    protected $_version;

    protected $_bootstrapFile;

    public $force;
    public $colors;
    public $coverageText;
    public $coverageClover;

    public function getConfiguration()
    {
        return $this->getGoal('phpunit.xml.dist');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    public function getBootstrapFile()
    {
        if ($this->_bootstrapFile === null) {
            $this->_bootstrapFile = Yii::createObject([
                'class'     => File::class,
                'template'  => 'phpunit/bootstrap.twig',
                'path'      => 'tests/_bootstrap.php',
            ]);
        }

        return $this->_bootstrapFile;
    }

    public function actionBootstrap()
    {
        if (!$this->getBootstrapFile()->exists()) {
            $this->getBootstrapFile()->save();
        }
    }

    public function actionMake()
    {
        return $this->actionRun();
    }

    public function actionRun()
    {
        $args = [];
        if ($this->coverageText) {
            $args[] = '--coverage-text';
        }
        if ($this->coverageClover) {
            $args[] = '--coverage-clover=' . (is_string($this->coverageClover) ? $this->coverageClover : 'coverage.clover');
        }
        if ($this->colors) {
            $args[] = '--colors' . (version_compare($this->getVersion(), '4.7.0', '>=') ? '=' . $this->colors : '');
        }

        return $this->passthru('phpunit', $args);
    }

    public function getVersion()
    {
        if ($this->_version === null) {
            $lines = $this->exec('phpunit', ['--version']);
            $a = explode(' ', $lines[0], 3)[1];
            $this->_version = $a;
        }

        return $this->_version;
    }

    public function actionGenfake($file)
    {
        $path = $this->buildFakePath($file);
        if (!$this->force && file_exists($path)) {
            Yii::warning("already exists: $path");
            return 1;
        }

        return $this->genFake($file, $path);
    }

    public function genFake($file, $path)
    {
        $text = $this->getView()->render('phpunit/fake.twig', [
            'class'         => $this->buildClass($file),
            'namespace'     => $this->buildTestNamespace(),
            'name'          => $file,
        ]);
        BaseHandler::write($path, $text);
    }

    public function actionGentest($file)
    {
        $path = $this->buildTestPath($file);
        if (!$this->force && file_exists($path)) {
            Yii::warning("already exists: $path");
            return 1;
        }

        return $this->genSkel($file);
    }

    public function genSkel($file)
    {
        return $this->passthru('phpunit-skelgen', [
            'generate-test', '--bootstrap', 'tests/_bootstrap.php', '--',
            $this->buildClass($file), $this->buildPath($file), $this->buildTestClass($file), $this->buildTestPath($file),
        ]);
    }

    public function buildNamespace($dir = '')
    {
        return $this->takePackage()->namespace . ($dir ? '\\' . strtr($dir, '/', '\\') : '');
    }

    public function buildTestNamespace($dir = 'tests\\unit')
    {
        return $this->buildNamespace($dir);
    }

    public function buildClass($file, $dir = '', $postfix = '')
    {
        return $this->buildNamespace($dir) . '\\' . strtr($file, '/', '\\') . $postfix;
    }

    public function buildTestClass($file, $dir = 'tests\\unit', $postfix = 'Test')
    {
        return $this->buildClass($file, $dir, $postfix);
    }

    public function buildPath($file, $dir = 'src', $prefix = '', $postfix = '')
    {
        return $dir . DIRECTORY_SEPARATOR . $prefix . $file . $postfix . '.php';
    }

    public function buildTestPath($file, $dir = 'tests/unit', $prefix = '', $postfix = 'Test')
    {
        return $this->buildPath($file, $dir, $prefix, $postfix);
    }

    public function buildFakePath($file, $dir = 'tests/unit', $prefix = 'Fake', $postfix = '')
    {
        return $this->buildPath($file, $dir, $prefix, $postfix);
    }
}


1		<?php
2
3		/*
4		* PHPUnit plugin for HiDev
5		*
6		* @link https://github.com/hiqdev/hidev-phpunit
7		* @package hidev-phpunit
8		* @license BSD-3-Clause
9		* @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
10		*/
11
12		namespace hidev\phpunit\controllers;
13
14		use hidev\base\File;
15		use hidev\handlers\BaseHandler;
16		use Yii;
17
18		/**
19		* Goal for Phpunit.
20		*/
21		class PhpunitController extends \hidev\controllers\CommonController
22		{
23		protected $_before = ['phpunit/bootstrap', 'phpunit.xml.dist'];
24
25		protected $_version;
26
27		protected $_bootstrapFile;
28
29		public $force;
30		public $colors;
31		public $coverageText;
32		public $coverageClover;
33
34		public function getConfiguration()
35		{
36		return $this->getGoal('phpunit.xml.dist');
		0 ignored issues – show Documentation Bug introduced 2016-02-19 10:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getGoal` does not exist on `object<hidev\phpunit\con...lers\PhpunitController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
37		}
38
39		public function getBootstrapFile()
40		{
41		if ($this->_bootstrapFile === null) {
42		$this->_bootstrapFile = Yii::createObject([
43		'class' => File::class,
44		'template' => 'phpunit/bootstrap.twig',
45		'path' => 'tests/_bootstrap.php',
46		]);
47		}
48
49		return $this->_bootstrapFile;
50		}
51
52		public function actionBootstrap()
53		{
54		if (!$this->getBootstrapFile()->exists()) {
55		$this->getBootstrapFile()->save();
56		}
57		}
58
59		public function actionMake()
60		{
61		return $this->actionRun();
62		}
63
64		public function actionRun()
65		{
66		$args = [];
67		if ($this->coverageText) {
68		$args[] = '--coverage-text';
69		}
70		if ($this->coverageClover) {
71		$args[] = '--coverage-clover=' . (is_string($this->coverageClover) ? $this->coverageClover : 'coverage.clover');
72		}
73		if ($this->colors) {
74		$args[] = '--colors' . (version_compare($this->getVersion(), '4.7.0', '>=') ? '=' . $this->colors : '');
75		}
76
77		return $this->passthru('phpunit', $args);
78		}
79
80		public function getVersion()
81		{
82		if ($this->_version === null) {
83		$lines = $this->exec('phpunit', ['--version']);
84		$a = explode(' ', $lines[0], 3)[1];
85		$this->_version = $a;
86		}
87
88		return $this->_version;
89		}
90
91	View Code Duplication	public function actionGenfake($file)
92		{
93		$path = $this->buildFakePath($file);
94		if (!$this->force && file_exists($path)) {
95		Yii::warning("already exists: $path");
96		return 1;
97		}
98
99		return $this->genFake($file, $path);
100		}
101
102		public function genFake($file, $path)
103		{
104		$text = $this->getView()->render('phpunit/fake.twig', [
105		'class' => $this->buildClass($file),
106		'namespace' => $this->buildTestNamespace(),
107		'name' => $file,
108		]);
109		BaseHandler::write($path, $text);
110		}
111
112	View Code Duplication	public function actionGentest($file)
113		{
114		$path = $this->buildTestPath($file);
115		if (!$this->force && file_exists($path)) {
116		Yii::warning("already exists: $path");
117		return 1;
118		}
119
120		return $this->genSkel($file);
121		}
122
123		public function genSkel($file)
124		{
125		return $this->passthru('phpunit-skelgen', [
126		'generate-test', '--bootstrap', 'tests/_bootstrap.php', '--',
127		$this->buildClass($file), $this->buildPath($file), $this->buildTestClass($file), $this->buildTestPath($file),
128		]);
129		}
130
131		public function buildNamespace($dir = '')
132		{
133		return $this->takePackage()->namespace . ($dir ? '\\' . strtr($dir, '/', '\\') : '');
134		}
135
136		public function buildTestNamespace($dir = 'tests\\unit')
137		{
138		return $this->buildNamespace($dir);
139		}
140
141		public function buildClass($file, $dir = '', $postfix = '')
142		{
143		return $this->buildNamespace($dir) . '\\' . strtr($file, '/', '\\') . $postfix;
144		}
145
146		public function buildTestClass($file, $dir = 'tests\\unit', $postfix = 'Test')
147		{
148		return $this->buildClass($file, $dir, $postfix);
149		}
150
151		public function buildPath($file, $dir = 'src', $prefix = '', $postfix = '')
152		{
153		return $dir . DIRECTORY_SEPARATOR . $prefix . $file . $postfix . '.php';
154		}
155
156		public function buildTestPath($file, $dir = 'tests/unit', $prefix = '', $postfix = 'Test')
157		{
158		return $this->buildPath($file, $dir, $prefix, $postfix);
159		}
160
161		public function buildFakePath($file, $dir = 'tests/unit', $prefix = 'Fake', $postfix = '')
162		{
163		return $this->buildPath($file, $dir, $prefix, $postfix);
164		}
165		}
166

hiqdev / hidev-phpunit

Push — master ( 1c2bc2...978448 )

src/controllers/PhpunitController.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like