Complex classes like VhostController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use VhostController, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
19 | class VhostController extends \hidev\controllers\CommonController |
||
20 | { |
||
21 | /** |
||
22 | * @var NginxController |
||
23 | */ |
||
24 | public $nginx; |
||
25 | |||
26 | /** |
||
27 | * @var integer |
||
28 | */ |
||
29 | public $timeout; |
||
30 | |||
31 | public $ssl; |
||
32 | |||
33 | public $_aliases = []; |
||
34 | |||
35 | protected $_sslDir; |
||
36 | protected $_ips = []; |
||
37 | protected $_localIps = []; |
||
38 | protected $_domain; |
||
39 | protected $_webDir; |
||
40 | protected $_logDir; |
||
41 | protected $_fpmSocket; |
||
42 | protected $_additionalConfig; |
||
43 | |||
44 | public function actionChmodSsl() |
||
51 | |||
52 | 1 | public function renderConf() |
|
58 | |||
59 | 1 | public function setDomain($value) |
|
63 | |||
64 | public function setDomains($domains) |
||
72 | |||
73 | 1 | public function getDomain() |
|
81 | |||
82 | 1 | public function setIp($value) |
|
86 | |||
87 | 1 | public function setIps($value) |
|
91 | |||
92 | 1 | public function getIps() |
|
100 | |||
101 | 1 | public function findIps() |
|
105 | |||
106 | 1 | public function setLocalIps($value) |
|
110 | |||
111 | 1 | public function getLocalIps() |
|
119 | |||
120 | 1 | public function setWebDir($value) |
|
124 | |||
125 | 1 | public function getWebDir() |
|
133 | |||
134 | 1 | public function setLogDir($value) |
|
138 | |||
139 | 1 | public function getLogDir() |
|
147 | |||
148 | 1 | public function setFpmSocket($value) |
|
152 | |||
153 | 1 | public function getFpmSocket() |
|
161 | |||
162 | 1 | public function setSslDir($value) |
|
169 | |||
170 | 1 | public function getSslDir() |
|
178 | |||
179 | public function setAliases($aliases) |
||
186 | |||
187 | 1 | public function getAliases() |
|
191 | |||
192 | 1 | public function getDomains() |
|
199 | |||
200 | 1 | public function getServerName() |
|
204 | |||
205 | 1 | public function getAdditionalConfig() |
|
209 | |||
210 | public function setAdditionalConfig($additinalConfig) |
||
214 | } |
||
215 |