Complex classes like VhostController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use VhostController, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
19 | class VhostController extends \hidev\controllers\CommonController |
||
20 | { |
||
21 | /** |
||
22 | * @var NginxController |
||
23 | */ |
||
24 | public $nginx; |
||
25 | |||
26 | /** |
||
27 | * @var integer |
||
28 | */ |
||
29 | public $timeout; |
||
30 | |||
31 | public $ssl; |
||
32 | |||
33 | public $_aliases = []; |
||
34 | |||
35 | protected $_sslDir; |
||
36 | protected $_ips = []; |
||
37 | protected $_localIps = []; |
||
38 | protected $_domain; |
||
39 | protected $_webDir; |
||
40 | protected $_logDir; |
||
41 | protected $_fpmSocket; |
||
42 | protected $_additionalConfig; |
||
43 | |||
44 | public function actionChmodSsl() |
||
45 | { |
||
46 | $dir = $this->getSslDir(); |
||
47 | $this->passthru('chown', ['-R', 'www-data', $dir, Sudo::create()]); |
||
48 | $this->passthru('chgrp', ['-R', 'www-data', $dir, Sudo::create()]); |
||
49 | $this->passthru('chmod', ['-R', 'o-rwx', $dir, Sudo::create()]); |
||
50 | } |
||
51 | |||
52 | 1 | public function renderConf() |
|
53 | { |
||
54 | 1 | return $this->nginx->render('default.twig', [ |
|
55 | 1 | 'this' => $this, |
|
56 | ]); |
||
57 | } |
||
58 | |||
59 | 1 | public function setDomain($value) |
|
63 | |||
64 | public function setDomains($domains) |
||
65 | { |
||
66 | if (!is_array($domains)) { |
||
67 | $domains = preg_split('/[\s,]+/', trim($domains)); |
||
68 | } |
||
69 | $this->_domain = array_shift($domains); |
||
70 | $this->_aliases = $domains; |
||
71 | } |
||
72 | |||
73 | 1 | public function getDomain() |
|
74 | { |
||
75 | 1 | if ($this->_domain === null || $this->_domain === 'default') { |
|
76 | 1 | $this->_domain = $this->takePackage()->name; |
|
77 | } |
||
78 | |||
79 | 1 | return $this->_domain; |
|
80 | } |
||
81 | |||
82 | 1 | public function setIp($value) |
|
86 | |||
87 | 1 | public function setIps($value) |
|
91 | |||
92 | 1 | public function getIps() |
|
93 | { |
||
94 | 1 | if (empty($this->_ips)) { |
|
95 | 1 | $this->_ips = $this->findIps(); |
|
96 | } |
||
97 | |||
98 | 1 | return $this->_ips; |
|
99 | } |
||
100 | |||
101 | 1 | public function findIps() |
|
105 | |||
106 | 1 | public function setLocalIps($value) |
|
110 | |||
111 | 1 | public function getLocalIps() |
|
112 | { |
||
113 | 1 | if (empty($this->_localIps)) { |
|
114 | 1 | $this->_localIps = $this->ssl ? ['127.0.0.1'] : $this->getIps(); |
|
115 | } |
||
116 | |||
117 | 1 | return $this->_localIps; |
|
118 | } |
||
119 | |||
120 | 1 | public function setWebDir($value) |
|
124 | |||
125 | 1 | public function getWebDir() |
|
126 | { |
||
127 | 1 | if ($this->_webDir === null) { |
|
128 | $this->_webDir = $this->takeGoal('start')->buildRootPath('web'); |
||
129 | } |
||
130 | |||
131 | 1 | return $this->_webDir; |
|
132 | } |
||
133 | |||
134 | 1 | public function setLogDir($value) |
|
138 | |||
139 | 1 | public function getLogDir() |
|
140 | { |
||
141 | 1 | if ($this->_logDir === null) { |
|
142 | 1 | $this->_logDir = $this->nginx->getLogDir(); |
|
143 | } |
||
144 | |||
145 | 1 | return $this->_logDir; |
|
146 | } |
||
147 | |||
148 | 1 | public function setFpmSocket($value) |
|
152 | |||
153 | 1 | public function getFpmSocket() |
|
154 | { |
||
155 | 1 | if ($this->_fpmSocket === null) { |
|
156 | 1 | $this->_fpmSocket = $this->nginx->getFpmSocket(); |
|
157 | } |
||
158 | |||
159 | 1 | return $this->_fpmSocket; |
|
160 | } |
||
161 | |||
162 | 1 | public function setSslDir($value) |
|
163 | { |
||
164 | 1 | $this->_sslDir = Yii::getAlias($value); |
|
165 | 1 | if ($this->_sslDir[0] !== '/') { |
|
166 | $this->_sslDir = $this->takeGoal('start')->buildRootPath($this->_sslDir); |
||
167 | } |
||
168 | 1 | } |
|
169 | |||
170 | 1 | public function getSslDir() |
|
171 | { |
||
172 | 1 | if ($this->_sslDir === null) { |
|
173 | $this->_sslDir = $this->takeGoal('start')->buildRootPath('ssl'); |
||
174 | } |
||
175 | |||
176 | 1 | return $this->_sslDir; |
|
177 | } |
||
178 | |||
179 | public function setAliases($aliases) |
||
180 | { |
||
181 | if (!is_array($aliases)) { |
||
182 | $aliases = preg_split('/[\s,]+/', trim($aliases)); |
||
183 | } |
||
184 | $this->_aliases = $aliases; |
||
185 | } |
||
186 | |||
187 | 1 | public function getAliases() |
|
191 | |||
192 | 1 | public function getDomains() |
|
199 | |||
200 | 1 | public function getServerName() |
|
204 | |||
205 | 1 | public function getAdditionalConfig() |
|
209 | |||
210 | public function setAdditionalConfig($additinalConfig) |
||
211 | { |
||
212 | $this->_additionalConfig = $additinalConfig; |
||
213 | } |
||
214 | } |
||
215 |